Re: [PATCH net-next 4/4] net/tls: byte swap device req TCP seq no upon setting

2019-04-25 Thread Saeed Mahameed
On Thu, 2019-04-25 at 12:38 -0700, Jakub Kicinski wrote: > On Thu, 25 Apr 2019 19:31:51 +, Saeed Mahameed wrote: > > > diff --git a/net/tls/tls_device.c b/net/tls/tls_device.c > > > index cb368efe3567..6686013b4e9e 100644 > > > --- a/net/tls/tls_device.c > > > +++ b/net/tls/tls_device.c > > > @

Re: [PATCH net-next 4/4] net/tls: byte swap device req TCP seq no upon setting

2019-04-25 Thread Jakub Kicinski
On Thu, 25 Apr 2019 19:31:51 +, Saeed Mahameed wrote: > > diff --git a/net/tls/tls_device.c b/net/tls/tls_device.c > > index cb368efe3567..6686013b4e9e 100644 > > --- a/net/tls/tls_device.c > > +++ b/net/tls/tls_device.c > > @@ -567,7 +567,7 @@ void (struct sock *sk, u32 > > seq, u64 rcd_sn) >

Re: [PATCH net-next 4/4] net/tls: byte swap device req TCP seq no upon setting

2019-04-25 Thread Saeed Mahameed
On Thu, 2019-04-25 at 09:56 -0700, Jakub Kicinski wrote: > To avoid a sparse warning byteswap the be32 sequence number > before it's stored in the atomic value. While at it drop > unnecessary brackets and use kernel's u64 type. > > Signed-off-by: Jakub Kicinski > Reviewed-by: Reviewed-by: Simon

[PATCH net-next 4/4] net/tls: byte swap device req TCP seq no upon setting

2019-04-25 Thread Jakub Kicinski
To avoid a sparse warning byteswap the be32 sequence number before it's stored in the atomic value. While at it drop unnecessary brackets and use kernel's u64 type. Signed-off-by: Jakub Kicinski Reviewed-by: Reviewed-by: Simon Horman --- include/net/tls.h| 2 +- net/tls/tls_device.c | 2 +-