On Tue, Oct 22, 2019 at 03:06:49AM +0200, Andrew Lunn wrote:
> Hi Ioana
>
> > +static int dpaa2_eth_connect_mac(struct dpaa2_eth_priv *priv)
> > +{
> > + struct fsl_mc_device *dpni_dev, *dpmac_dev;
> > + struct dpaa2_mac *mac;
> > + int err;
> > +
> > + dpni_dev = to_fsl_mc_device(priv->ne
> Hi Ioana
>
Hi Andrew
> > +static int dpaa2_eth_connect_mac(struct dpaa2_eth_priv *priv) {
> > + struct fsl_mc_device *dpni_dev, *dpmac_dev;
> > + struct dpaa2_mac *mac;
> > + int err;
> > +
> > + dpni_dev = to_fsl_mc_device(priv->net_dev->dev.parent);
> > + dpmac_dev = fsl_mc_get_end
> Subject: Re: [PATCH net-next 3/4] dpaa2-eth: add MAC/PHY support through
> phylink
>
> On Tue, Oct 22, 2019 at 01:50:27AM +0300, Ioana Ciornei wrote:
> > + mac->phylink_config.dev = &net_dev->dev;
> > + mac->phylink_config.type = PHYLINK_NETDEV;
> &
On Tue, Oct 22, 2019 at 01:50:27AM +0300, Ioana Ciornei wrote:
> + mac->phylink_config.dev = &net_dev->dev;
> + mac->phylink_config.type = PHYLINK_NETDEV;
> +
> + phylink = phylink_create(&mac->phylink_config,
> + of_fwnode_handle(dpmac_node), mac->if_mode,
Hi Ioana,
I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Ioana-Ciornei/dpaa2-eth-add-MAC-PHY-support-through-phylink/20191022-075637
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.g
Hi Ioana
> +static int dpaa2_eth_connect_mac(struct dpaa2_eth_priv *priv)
> +{
> + struct fsl_mc_device *dpni_dev, *dpmac_dev;
> + struct dpaa2_mac *mac;
> + int err;
> +
> + dpni_dev = to_fsl_mc_device(priv->net_dev->dev.parent);
> + dpmac_dev = fsl_mc_get_endpoint(dpni_dev);
The dpaa2-eth driver now has support for connecting to its associated
PHY device found through standard OF bindings.
This happens when the DPNI object (that the driver probes on) gets
connected to a DPMAC. When that happens, the device tree is looked up by
the DPMAC ID, and the associated PHY bind
