> Subject: Re: [PATCH net-next 3/4] dpaa2-eth: add MAC/PHY support through > phylink > > On Tue, Oct 22, 2019 at 01:50:27AM +0300, Ioana Ciornei wrote: > > + mac->phylink_config.dev = &net_dev->dev; > > + mac->phylink_config.type = PHYLINK_NETDEV; > > + > > + phylink = phylink_create(&mac->phylink_config, > > + of_fwnode_handle(dpmac_node), mac- > >if_mode, > > + &dpaa2_mac_phylink_ops); > > Does this mean we didn't need to go through the removal of netdev from > phylink after all? >
No, it doesn't mean that. The change was accepted because it added support for multi-gbps speeds on DSA CPU ports by using a phylink instance based on the dsa_switch device. Maxime's initial mail is here - https://www.spinics.net/lists/netdev/msg570450.html. Ioana