Re: [PATCH net-next 3/3] net: bcmgenet: Fix coalescing settings handling

2018-03-29 Thread Florian Fainelli
On 03/29/2018 10:51 AM, Doug Berger wrote: > On 03/27/2018 12:47 PM, Florian Fainelli wrote: >> There were a number of issues with setting the RX coalescing parameters: >> >> - we would not be preserving values that would have been configured >> across close/open calls, instead we would always re

Re: [PATCH net-next 3/3] net: bcmgenet: Fix coalescing settings handling

2018-03-29 Thread Doug Berger
On 03/29/2018 10:51 AM, Doug Berger wrote: > On 03/27/2018 12:47 PM, Florian Fainelli wrote: >> There were a number of issues with setting the RX coalescing parameters: >> >> - we would not be preserving values that would have been configured >> across close/open calls, instead we would always re

Re: [PATCH net-next 3/3] net: bcmgenet: Fix coalescing settings handling

2018-03-29 Thread Doug Berger
On 03/27/2018 12:47 PM, Florian Fainelli wrote: > There were a number of issues with setting the RX coalescing parameters: > > - we would not be preserving values that would have been configured > across close/open calls, instead we would always reset to no timeout > and 1 interrupt per packet

Re: [PATCH net-next 3/3] net: bcmgenet: Fix coalescing settings handling

2018-03-28 Thread Tal Gilboa
On 3/27/2018 10:47 PM, Florian Fainelli wrote: There were a number of issues with setting the RX coalescing parameters: - we would not be preserving values that would have been configured across close/open calls, instead we would always reset to no timeout and 1 interrupt per packet, this

[PATCH net-next 3/3] net: bcmgenet: Fix coalescing settings handling

2018-03-27 Thread Florian Fainelli
There were a number of issues with setting the RX coalescing parameters: - we would not be preserving values that would have been configured across close/open calls, instead we would always reset to no timeout and 1 interrupt per packet, this would also prevent DIM from setting its default u