Re: [kbuild-all] Re: [PATCH net-next 2/4] net: phy: dp83869: Set opmode from straps

2020-05-19 Thread Philip Li
On Tue, May 19, 2020 at 12:40:37PM -0500, Dan Murphy wrote: > kbuild > > On 5/19/20 12:19 PM, kbuild test robot wrote: > > Hi Dan, > > > > I love your patch! Perhaps something to improve: > > > > [auto build test WARNING on net-next/master] > > [also build test WARNING on robh/for-next sparc-nex

Re: [PATCH net-next 2/4] net: phy: dp83869: Set opmode from straps

2020-05-19 Thread kbuild test robot
Hi Dan, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] [also build test WARNING on robh/for-next sparc-next/master net/master linus/master v5.7-rc6 next-20200519] [if your patch is applied to the wrong git tree, please drop us a note to help improve

Re: [PATCH net-next 2/4] net: phy: dp83869: Set opmode from straps

2020-05-19 Thread Andrew Lunn
On Tue, May 19, 2020 at 01:59:16PM -0500, Dan Murphy wrote: > Jakub > > On 5/19/20 1:48 PM, Jakub Kicinski wrote: > > On Tue, 19 May 2020 13:41:40 -0500 Dan Murphy wrote: > > > > Is this now a standard GCC warning? Or have you turned on extra > > > > checking? > > > I still was not able to reprodu

Re: [PATCH net-next 2/4] net: phy: dp83869: Set opmode from straps

2020-05-19 Thread Dan Murphy
Jakub On 5/19/20 1:48 PM, Jakub Kicinski wrote: On Tue, 19 May 2020 13:41:40 -0500 Dan Murphy wrote: Is this now a standard GCC warning? Or have you turned on extra checking? I still was not able to reproduce this warning with gcc-9.2.  I would like to know the same W=1 + gcc-10 here, also cu

Re: [PATCH net-next 2/4] net: phy: dp83869: Set opmode from straps

2020-05-19 Thread Jakub Kicinski
On Tue, 19 May 2020 13:41:40 -0500 Dan Murphy wrote: > > Is this now a standard GCC warning? Or have you turned on extra > > checking? > I still was not able to reproduce this warning with gcc-9.2.  I would > like to know the same W=1 + gcc-10 here, also curious to know which one of the two mak

Re: [PATCH net-next 2/4] net: phy: dp83869: Set opmode from straps

2020-05-19 Thread Dan Murphy
Andrew On 5/19/20 1:29 PM, Andrew Lunn wrote: On Tue, May 19, 2020 at 09:58:18AM -0700, Jakub Kicinski wrote: On Tue, 19 May 2020 09:18:11 -0500 Dan Murphy wrote: If the op-mode for the device is not set in the device tree then set the strapped op-mode and store it for later configuration. Si

Re: [PATCH net-next 2/4] net: phy: dp83869: Set opmode from straps

2020-05-19 Thread Andrew Lunn
On Tue, May 19, 2020 at 09:58:18AM -0700, Jakub Kicinski wrote: > On Tue, 19 May 2020 09:18:11 -0500 Dan Murphy wrote: > > If the op-mode for the device is not set in the device tree then set > > the strapped op-mode and store it for later configuration. > > > > Signed-off-by: Dan Murphy > > ../

Re: [PATCH net-next 2/4] net: phy: dp83869: Set opmode from straps

2020-05-19 Thread Dan Murphy
Jakub On 5/19/20 12:40 PM, Dan Murphy wrote: Jakub On 5/19/20 11:58 AM, Jakub Kicinski wrote: On Tue, 19 May 2020 09:18:11 -0500 Dan Murphy wrote: If the op-mode for the device is not set in the device tree then set the strapped op-mode and store it for later configuration. Signed-off-by: Da

Re: [PATCH net-next 2/4] net: phy: dp83869: Set opmode from straps

2020-05-19 Thread Dan Murphy
kbuild On 5/19/20 12:19 PM, kbuild test robot wrote: Hi Dan, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] [also build test WARNING on robh/for-next sparc-next/master net/master linus/master v5.7-rc6 next-20200518] [if your patch is applied to t

Re: [PATCH net-next 2/4] net: phy: dp83869: Set opmode from straps

2020-05-19 Thread Dan Murphy
Jakub On 5/19/20 11:58 AM, Jakub Kicinski wrote: On Tue, 19 May 2020 09:18:11 -0500 Dan Murphy wrote: If the op-mode for the device is not set in the device tree then set the strapped op-mode and store it for later configuration. Signed-off-by: Dan Murphy ../drivers/net/phy/dp83869.c: In fun

Re: [PATCH net-next 2/4] net: phy: dp83869: Set opmode from straps

2020-05-19 Thread kbuild test robot
Hi Dan, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] [also build test WARNING on robh/for-next sparc-next/master net/master linus/master v5.7-rc6 next-20200518] [if your patch is applied to the wrong git tree, please drop us a note to help improve

Re: [PATCH net-next 2/4] net: phy: dp83869: Set opmode from straps

2020-05-19 Thread Jakub Kicinski
On Tue, 19 May 2020 09:18:11 -0500 Dan Murphy wrote: > If the op-mode for the device is not set in the device tree then set > the strapped op-mode and store it for later configuration. > > Signed-off-by: Dan Murphy ../drivers/net/phy/dp83869.c: In function0 dp83869_set_strapped_mode: ../drivers/

[PATCH net-next 2/4] net: phy: dp83869: Set opmode from straps

2020-05-19 Thread Dan Murphy
If the op-mode for the device is not set in the device tree then set the strapped op-mode and store it for later configuration. Signed-off-by: Dan Murphy --- drivers/net/phy/dp83869.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/dp8386