Re: [PATCH net-next 1/7] net: phy: Extract genphy_c45_read_abilities from marvell10g

2019-01-21 Thread Andrew Lunn
> Yes, the term 'Ability' is used in the 802.3 specifications, both in > the register names and the descriptions. O.K, please keep with what the standard uses. Andrew

Re: [PATCH net-next 1/7] net: phy: Extract genphy_c45_read_abilities from marvell10g

2019-01-21 Thread Maxime Chevallier
Hello Andrew, On Sun, 20 Jan 2019 19:51:07 +0100 Andrew Lunn wrote: >On Fri, Jan 18, 2019 at 04:23:46PM +0100, Maxime Chevallier wrote: >> Marvell 10G PHY driver has a generic way of initializing the supported >> link modes by reading the PHY's C45 PMA abilities. This can be made >> generic, sin

Re: [PATCH net-next 1/7] net: phy: Extract genphy_c45_read_abilities from marvell10g

2019-01-20 Thread Andrew Lunn
On Fri, Jan 18, 2019 at 04:23:46PM +0100, Maxime Chevallier wrote: > Marvell 10G PHY driver has a generic way of initializing the supported > link modes by reading the PHY's C45 PMA abilities. This can be made > generic, since these registers are part of the 802.3 specifications. > > This commit e

[PATCH net-next 1/7] net: phy: Extract genphy_c45_read_abilities from marvell10g

2019-01-18 Thread Maxime Chevallier
Marvell 10G PHY driver has a generic way of initializing the supported link modes by reading the PHY's C45 PMA abilities. This can be made generic, since these registers are part of the 802.3 specifications. This commit extracts the config_init link_mode initialization code from marvell10g and use