Re: [PATCH net-next 1/7] net: aquantia: replace internal driver version code with uts

2019-06-24 Thread David Miller
From: Igor Russkikh Date: Mon, 24 Jun 2019 11:02:54 + > >> >>> Devlink has just gained something similar to ethtool -i. Maybe we >>> should get the devlink core to also report the kernel version? >> >> I don't think we have the driver version at all there, my usual >> inclination being to

Re: [PATCH net-next 1/7] net: aquantia: replace internal driver version code with uts

2019-06-24 Thread Igor Russkikh
> >> Devlink has just gained something similar to ethtool -i. Maybe we >> should get the devlink core to also report the kernel version? > > I don't think we have the driver version at all there, my usual > inclination being to not duplicate information across APIs. Do we > have non-hypothetic

Re: [PATCH net-next 1/7] net: aquantia: replace internal driver version code with uts

2019-06-23 Thread Jakub Kicinski
On Sat, 22 Jun 2019 17:05:14 +0200, Andrew Lunn wrote: > On Sat, Jun 22, 2019 at 01:45:12PM +, Igor Russkikh wrote: > > As it was discussed some time previously, driver is better to > > report kernel version string, as it in a best way identifies > > the codebase. > > > > Signed-off-by: Igor R

Re: [PATCH net-next 1/7] net: aquantia: replace internal driver version code with uts

2019-06-22 Thread Andrew Lunn
On Sat, Jun 22, 2019 at 01:45:12PM +, Igor Russkikh wrote: > As it was discussed some time previously, driver is better to > report kernel version string, as it in a best way identifies > the codebase. > > Signed-off-by: Igor Russkikh Nice. Devlink has just gained something similar to ethto

[PATCH net-next 1/7] net: aquantia: replace internal driver version code with uts

2019-06-22 Thread Igor Russkikh
As it was discussed some time previously, driver is better to report kernel version string, as it in a best way identifies the codebase. Signed-off-by: Igor Russkikh --- drivers/net/ethernet/aquantia/atlantic/aq_cfg.h | 7 +++ drivers/net/ethernet/aquantia/atlantic/ver.h| 5 - 2 file