On Sat, 22 Jun 2019 17:05:14 +0200, Andrew Lunn wrote: > On Sat, Jun 22, 2019 at 01:45:12PM +0000, Igor Russkikh wrote: > > As it was discussed some time previously, driver is better to > > report kernel version string, as it in a best way identifies > > the codebase. > > > > Signed-off-by: Igor Russkikh <igor.russk...@aquantia.com> > > Nice.
Indeed! > Devlink has just gained something similar to ethtool -i. Maybe we > should get the devlink core to also report the kernel version? I don't think we have the driver version at all there, my usual inclination being to not duplicate information across APIs. Do we have non-hypothetical instances of users reporting ethtool -i without uname output? Admittedly I may work with above-average Linux-trained engineers :S Would it be okay to just get devlink user space to use uname() to get the info?