Re: [PATCH net-next 1/1] tc-testing: Restore original behaviour for namespaces in tdc

2019-06-25 Thread David Miller
From: Lucas Bates Date: Mon, 24 Jun 2019 21:00:27 -0400 > This patch restores the original behaviour for tdc prior to the > introduction of the plugin system, where the network namespace > functionality was split from the main script. > > It introduces the concept of required plugins for testcas

Re: [PATCH net-next 1/1] tc-testing: Restore original behaviour for namespaces in tdc

2019-06-25 Thread Nicolas Dichtel
Le 25/06/2019 à 03:00, Lucas Bates a écrit : > This patch restores the original behaviour for tdc prior to the > introduction of the plugin system, where the network namespace > functionality was split from the main script. > > It introduces the concept of required plugins for testcases, > and wil

Re: [PATCH net-next 1/1] tc-testing: Restore original behaviour for namespaces in tdc

2019-06-25 Thread Davide Caratti
On Mon, 2019-06-24 at 21:00 -0400, Lucas Bates wrote: > This patch restores the original behaviour for tdc prior to the > introduction of the plugin system, where the network namespace > functionality was split from the main script. > > It introduces the concept of required plugins for testcases,

[PATCH net-next 1/1] tc-testing: Restore original behaviour for namespaces in tdc

2019-06-24 Thread Lucas Bates
This patch restores the original behaviour for tdc prior to the introduction of the plugin system, where the network namespace functionality was split from the main script. It introduces the concept of required plugins for testcases, and will automatically load any plugin that isn't already enable

Re: [RFC PATCH net-next 1/1] tc-testing: Restore original behaviour for namespaces in tdc

2019-06-21 Thread Nicolas Dichtel
Le 21/06/2019 à 02:45, Lucas Bates a écrit : [snip] > Very true. I think I just put that one in quickly and meant to come > back to it later, but either way it's a bit too vague. I understand. As a developer, we tend to focus on the technical part, but we need to remember to look at the big picture

Re: [RFC PATCH net-next 1/1] tc-testing: Restore original behaviour for namespaces in tdc

2019-06-20 Thread Lucas Bates
On Tue, Jun 18, 2019 at 4:52 AM Nicolas Dichtel wrote: > >> From my point of view, if all tests are not successful by default, it > >> scares > >> users and prevent them to use those tests suite to validate their patches. > > > > For me, explicitly telling the user that a test was skipped, and /w

Re: [RFC PATCH net-next 1/1] tc-testing: Restore original behaviour for namespaces in tdc

2019-06-18 Thread Nicolas Dichtel
Le 17/06/2019 à 04:04, Lucas Bates a écrit : > On Fri, Jun 14, 2019 at 5:37 AM Nicolas Dichtel > wrote: [snip] > The tests that make use of DEV2 are intended to be run with a physical > NIC. This feature was originally submitted by Chris Mi from Mellanox > back in 2017 (commit 31c2611b) to reprod

Re: [RFC PATCH net-next 1/1] tc-testing: Restore original behaviour for namespaces in tdc

2019-06-16 Thread Lucas Bates
On Fri, Jun 14, 2019 at 5:37 AM Nicolas Dichtel wrote: > > Le 05/06/2019 à 23:08, Lucas Bates a écrit : > > Apologies for the delay in getting this out. I've been busy > > with other things and this change was a little trickier than > > I expected. > > > > This patch restores the original behaviou

Re: [RFC PATCH net-next 1/1] tc-testing: Restore original behaviour for namespaces in tdc

2019-06-14 Thread Nicolas Dichtel
Le 05/06/2019 à 23:08, Lucas Bates a écrit : > Apologies for the delay in getting this out. I've been busy > with other things and this change was a little trickier than > I expected. > > This patch restores the original behaviour for tdc prior to the > introduction of the plugin system, where the

Re: [RFC PATCH net-next 1/1] tc-testing: Restore original behaviour for namespaces in tdc

2019-06-07 Thread Lucas Bates
On Fri, Jun 7, 2019 at 8:18 AM Davide Caratti wrote: > From what I see, it is a fix for the reported problem (e.g. tests failing > because of 'nsPlugin' uninstalled). And, I want to followup fixing the > bpf.json in tc-actions, so that > > # ./tdc.py -l -c bpf | grep eBPF > e939: (actions, bpf)

Re: [RFC PATCH net-next 1/1] tc-testing: Restore original behaviour for namespaces in tdc

2019-06-07 Thread Davide Caratti
On Wed, 2019-06-05 at 17:08 -0400, Lucas Bates wrote: > Apologies for the delay in getting this out. I've been busy > with other things and this change was a little trickier than > I expected. > > This patch restores the original behaviour for tdc prior to the > introduction of the plugin system,

[RFC PATCH net-next 1/1] tc-testing: Restore original behaviour for namespaces in tdc

2019-06-05 Thread Lucas Bates
Apologies for the delay in getting this out. I've been busy with other things and this change was a little trickier than I expected. This patch restores the original behaviour for tdc prior to the introduction of the plugin system, where the network namespace functionality was split from the main