Le 17/06/2019 à 04:04, Lucas Bates a écrit : > On Fri, Jun 14, 2019 at 5:37 AM Nicolas Dichtel > <nicolas.dich...@6wind.com> wrote: [snip] > The tests that make use of DEV2 are intended to be run with a physical > NIC. This feature was originally submitted by Chris Mi from Mellanox > back in 2017 (commit 31c2611b) to reproduce a kernel panic, with d052 > being the first test case submitted. Ok.
> > Originally they were silently skipped, but once I added TdcResults.py > this changed so they would be tracked and reported as skipped. > >> From my point of view, if all tests are not successful by default, it scares >> users and prevent them to use those tests suite to validate their patches. > > For me, explicitly telling the user that a test was skipped, and /why/ > it was skipped, is far better than excluding the test from the > results: I don't want to waste someone's time with troubleshooting the > script if they're expecting to see results for those tests when > running tdc and nothing appears, or worse yet, stop using it because > they think it doesn't work properly. > > I do believe the skip message should be improved so it better > indicates why those tests are being skipped. And the '-d' feature > should be documented. How do these changes sound? If the error message is clear enough, I agree with you. The skip message should not feel like an error message ;-) Thank you, Nicolas
