Re: [PATCH net-next 03/14] bnxt_en: Refactor bnxt_sriov_enable().

2019-08-31 Thread Leon Romanovsky
On Fri, Aug 30, 2019 at 09:00:27AM -0700, Michael Chan wrote: > On Fri, Aug 30, 2019 at 2:18 AM Leon Romanovsky wrote: > > > > On Mon, Aug 26, 2019 at 09:00:45AM +0300, Leon Romanovsky wrote: > > > On Sun, Aug 25, 2019 at 11:54:54PM -0400, Michael Chan wrote: > > > > Refactor the hardware/firmware

Re: [PATCH net-next 03/14] bnxt_en: Refactor bnxt_sriov_enable().

2019-08-30 Thread Michael Chan
On Fri, Aug 30, 2019 at 2:18 AM Leon Romanovsky wrote: > > On Mon, Aug 26, 2019 at 09:00:45AM +0300, Leon Romanovsky wrote: > > On Sun, Aug 25, 2019 at 11:54:54PM -0400, Michael Chan wrote: > > > Refactor the hardware/firmware configuration portion in > > > bnxt_sriov_enable() into a new function

Re: [PATCH net-next 03/14] bnxt_en: Refactor bnxt_sriov_enable().

2019-08-30 Thread Leon Romanovsky
On Mon, Aug 26, 2019 at 09:00:45AM +0300, Leon Romanovsky wrote: > On Sun, Aug 25, 2019 at 11:54:54PM -0400, Michael Chan wrote: > > Refactor the hardware/firmware configuration portion in > > bnxt_sriov_enable() into a new function bnxt_cfg_hw_sriov(). This > > new function can be called after a

Re: [PATCH net-next 03/14] bnxt_en: Refactor bnxt_sriov_enable().

2019-08-25 Thread Michael Chan
On Sun, Aug 25, 2019 at 10:36 PM David Miller wrote: > > From: Michael Chan > Date: Sun, 25 Aug 2019 23:54:54 -0400 > > > @@ -687,6 +687,32 @@ static int bnxt_func_cfg(struct bnxt *bp, int num_vfs) > > return bnxt_hwrm_func_cfg(bp, num_vfs); > > } > > > > +int bnxt_cfg_hw_sriov(str

Re: [PATCH net-next 03/14] bnxt_en: Refactor bnxt_sriov_enable().

2019-08-25 Thread Leon Romanovsky
On Sun, Aug 25, 2019 at 11:54:54PM -0400, Michael Chan wrote: > Refactor the hardware/firmware configuration portion in > bnxt_sriov_enable() into a new function bnxt_cfg_hw_sriov(). This > new function can be called after a firmware reset to reconfigure the > VFs previously enabled. I wonder wha

Re: [PATCH net-next 03/14] bnxt_en: Refactor bnxt_sriov_enable().

2019-08-25 Thread David Miller
From: Michael Chan Date: Sun, 25 Aug 2019 23:54:54 -0400 > @@ -687,6 +687,32 @@ static int bnxt_func_cfg(struct bnxt *bp, int num_vfs) > return bnxt_hwrm_func_cfg(bp, num_vfs); > } > > +int bnxt_cfg_hw_sriov(struct bnxt *bp, int *num_vfs) > +{ > + int rc; > + > + /* Regis

[PATCH net-next 03/14] bnxt_en: Refactor bnxt_sriov_enable().

2019-08-25 Thread Michael Chan
Refactor the hardware/firmware configuration portion in bnxt_sriov_enable() into a new function bnxt_cfg_hw_sriov(). This new function can be called after a firmware reset to reconfigure the VFs previously enabled. When VFs need to be reconfigured dynamically after firmwware reset, the configurat