Re: [PATCH net-next 01/10] r8169: add basic phylib support

2018-07-03 Thread Heiner Kallweit
On 03.07.2018 18:42, Florian Fainelli wrote: > > > On 07/02/2018 02:15 PM, Heiner Kallweit wrote: >> On 02.07.2018 23:02, Andrew Lunn wrote: +static int r8169_mdio_read_reg(struct mii_bus *mii_bus, int phyaddr, int phyreg) +{ + struct rtl8169_private *tp = mii_bus->priv; >>>

Re: [PATCH net-next 01/10] r8169: add basic phylib support

2018-07-03 Thread Florian Fainelli
On 07/02/2018 02:15 PM, Heiner Kallweit wrote: > On 02.07.2018 23:02, Andrew Lunn wrote: >>> +static int r8169_mdio_read_reg(struct mii_bus *mii_bus, int phyaddr, int >>> phyreg) >>> +{ >>> + struct rtl8169_private *tp = mii_bus->priv; >>> + >>> + return rtl_readphy(tp, phyreg); >> >> So th

Re: [PATCH net-next 01/10] r8169: add basic phylib support

2018-07-02 Thread Heiner Kallweit
On 02.07.2018 23:02, Andrew Lunn wrote: >> +static int r8169_mdio_read_reg(struct mii_bus *mii_bus, int phyaddr, int >> phyreg) >> +{ >> +struct rtl8169_private *tp = mii_bus->priv; >> + >> +return rtl_readphy(tp, phyreg); > > So there is no support for phyaddr? > Right, the chip can acc

Re: [PATCH net-next 01/10] r8169: add basic phylib support

2018-07-02 Thread Andrew Lunn
> +static int r8169_mdio_read_reg(struct mii_bus *mii_bus, int phyaddr, int > phyreg) > +{ > + struct rtl8169_private *tp = mii_bus->priv; > + > + return rtl_readphy(tp, phyreg); So there is no support for phyaddr? It would be better to trap the phyaddr which are not supported and return

[PATCH net-next 01/10] r8169: add basic phylib support

2018-07-02 Thread Heiner Kallweit
Add basic phylib support to r8169. All now unneeded old PHY handling code will be removed in subsequent patches. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/Kconfig | 1 + drivers/net/ethernet/realtek/r8169.c | 146 +-- 2 files changed, 115 insertion