On 07/02/2018 02:15 PM, Heiner Kallweit wrote: > On 02.07.2018 23:02, Andrew Lunn wrote: >>> +static int r8169_mdio_read_reg(struct mii_bus *mii_bus, int phyaddr, int >>> phyreg) >>> +{ >>> + struct rtl8169_private *tp = mii_bus->priv; >>> + >>> + return rtl_readphy(tp, phyreg); >> >> So there is no support for phyaddr? >> > Right, the chip can access only the one internal PHY, therefore it > doesn't support phyaddr. Then you might also want to set mii_bus->phy_mask accordingly such that only the internal PHY address bit is cleared there? -- Florian
- [PATCH net-next 00/10] r8169: add phylib support Heiner Kallweit
- [PATCH net-next 03/10] r8169: replace open-coded PHY... Heiner Kallweit
- [PATCH net-next 01/10] r8169: add basic phylib suppo... Heiner Kallweit
- Re: [PATCH net-next 01/10] r8169: add basic phyl... Andrew Lunn
- Re: [PATCH net-next 01/10] r8169: add basic ... Heiner Kallweit
- Re: [PATCH net-next 01/10] r8169: add ba... Florian Fainelli
- Re: [PATCH net-next 01/10] r8169: a... Heiner Kallweit
- [PATCH net-next 05/10] r8169: use phy_ethtool_nway_r... Heiner Kallweit
- [PATCH net-next 08/10] r8169: remove rtl8169_set_spe... Heiner Kallweit
- Re: [PATCH net-next 08/10] r8169: remove rtl8169... Andrew Lunn
- Re: [PATCH net-next 08/10] r8169: remove rtl... Heiner Kallweit
- Re: [PATCH net-next 08/10] r8169: remove... Andrew Lunn
- Re: [PATCH net-next 08/10] r8169: r... Heiner Kallweit
- [PATCH net-next 10/10] r8169: don't read chip phy st... Heiner Kallweit
- [PATCH net-next 07/10] r8169: migrate speed_down fun... Heiner Kallweit