Re: [PATCH net-next 0/2] net: ipv4: remove erroneous advancement of list pointer

2019-06-26 Thread Florian Westphal
Ran Rozenstein wrote: > The test dose stress on the interface by running this 2 commands in loop: > > command is: /sbin/ip -f inet addr add $IP/16 brd + dev ens8f1 > command is: ifconfig ens8f1 $IP netmask 255.255.0.0 > > when $IP change every iteration. > > It execute every second when we see

Re: [PATCH net-next 0/2] net: ipv4: remove erroneous advancement of list pointer

2019-06-26 Thread Florian Westphal
Ran Rozenstein wrote: > The test dose stress on the interface by running this 2 commands in loop: > > command is: /sbin/ip -f inet addr add $IP/16 brd + dev ens8f1 > command is: ifconfig ens8f1 $IP netmask 255.255.0.0 > > when $IP change every iteration. > > It execute every second when we see

RE: [PATCH net-next 0/2] net: ipv4: remove erroneous advancement of list pointer

2019-06-26 Thread Ran Rozenstein
> -Original Message- > From: Florian Westphal [mailto:f...@strlen.de] > Sent: Tuesday, June 25, 2019 12:19 > To: Ran Rozenstein > Cc: Tariq Toukan ; Florian Westphal ; > netdev@vger.kernel.org; Maor Gottlieb ; > eduma...@google.com > Subject: Re: [PATCH net-nex

Re: [PATCH net-next 0/2] net: ipv4: remove erroneous advancement of list pointer

2019-06-25 Thread Florian Westphal
Ran Rozenstein wrote: > > On 6/17/2019 5:02 PM, Florian Westphal wrote: > > > Tariq reported a soft lockup on net-next that Mellanox was able to > > > bisect to 2638eb8b50cf ("net: ipv4: provide __rcu annotation for > > > ifa_list"). > > > > > > While reviewing above patch I found a regression wh

RE: [PATCH net-next 0/2] net: ipv4: remove erroneous advancement of list pointer

2019-06-25 Thread Ran Rozenstein
> -Original Message- > From: Tariq Toukan > Sent: Monday, June 17, 2019 19:16 > To: Florian Westphal ; netdev@vger.kernel.org > Cc: Ran Rozenstein ; Maor Gottlieb > ; eduma...@google.com > Subject: Re: [PATCH net-next 0/2] net: ipv4: remove erroneous > adv

Re: [PATCH net-next 0/2] net: ipv4: remove erroneous advancement of list pointer

2019-06-17 Thread David Miller
From: Florian Westphal Date: Mon, 17 Jun 2019 16:02:26 +0200 > Tariq reported a soft lockup on net-next that Mellanox was able to > bisect to 2638eb8b50cf ("net: ipv4: provide __rcu annotation for ifa_list"). > > While reviewing above patch I found a regression when addresses have a > lifetime s

Re: [PATCH net-next 0/2] net: ipv4: remove erroneous advancement of list pointer

2019-06-17 Thread Tariq Toukan
On 6/17/2019 5:02 PM, Florian Westphal wrote: > Tariq reported a soft lockup on net-next that Mellanox was able to > bisect to 2638eb8b50cf ("net: ipv4: provide __rcu annotation for ifa_list"). > > While reviewing above patch I found a regression when addresses have a > lifetime specified. > >

[PATCH net-next 0/2] net: ipv4: remove erroneous advancement of list pointer

2019-06-17 Thread Florian Westphal
Tariq reported a soft lockup on net-next that Mellanox was able to bisect to 2638eb8b50cf ("net: ipv4: provide __rcu annotation for ifa_list"). While reviewing above patch I found a regression when addresses have a lifetime specified. Second patch extends rtnetlink.sh to trigger crash (without fi