Re: [PATCH net-next] tcp: fix zerocopy and notsent_lowat issues

2019-03-26 Thread Eric Dumazet
On 03/25/2019 01:50 PM, Willem de Bruijn wrote: > On Mon, Mar 25, 2019 at 4:48 PM Soheil Hassas Yeganeh > wrote: >> >> On Mon, Mar 25, 2019 at 4:44 PM Eric Dumazet wrote: >>> >>> My recent patch had at least two problems : >>> >>> 1) TX zerocopy wants notification when skb is acknowledged, >>

Re: [PATCH net-next] tcp: fix zerocopy and notsent_lowat issues

2019-03-25 Thread Willem de Bruijn
On Mon, Mar 25, 2019 at 4:48 PM Soheil Hassas Yeganeh wrote: > > On Mon, Mar 25, 2019 at 4:44 PM Eric Dumazet wrote: > > > > My recent patch had at least two problems : > > > > 1) TX zerocopy wants notification when skb is acknowledged, > >thus we need to call skb_zcopy_clear() if the skb is

Re: [PATCH net-next] tcp: fix zerocopy and notsent_lowat issues

2019-03-25 Thread Soheil Hassas Yeganeh
On Mon, Mar 25, 2019 at 4:44 PM Eric Dumazet wrote: > > My recent patch had at least two problems : > > 1) TX zerocopy wants notification when skb is acknowledged, >thus we need to call skb_zcopy_clear() if the skb is >cached into sk->sk_tx_skb_cache > > 2) Some applications might expect p

[PATCH net-next] tcp: fix zerocopy and notsent_lowat issues

2019-03-25 Thread Eric Dumazet
My recent patch had at least two problems : 1) TX zerocopy wants notification when skb is acknowledged, thus we need to call skb_zcopy_clear() if the skb is cached into sk->sk_tx_skb_cache 2) Some applications might expect precise EPOLLOUT notifications, so we need to update sk->sk_wmem_