Re: [PATCH net-next] tcp: always send a quick ack when quickacks are enabled

2015-07-07 Thread Jonathan Maxwell
> On Tue, 2015-07-07 at 14:22 +1000, Jon Maxwell wrote: > > > > @@ -4887,6 +4884,7 @@ static inline void tcp_data_snd_check(struct sock > > *sk) > > static void __tcp_ack_snd_check(struct sock *sk, int ofo_possible) > > { > > struct tcp_sock *tp = tcp_sk(sk); > > +const struct dst_entry

Re: [PATCH net-next] tcp: always send a quick ack when quickacks are enabled

2015-07-07 Thread Eric Dumazet
On Tue, 2015-07-07 at 14:22 +1000, Jon Maxwell wrote: > @@ -4887,6 +4884,7 @@ static inline void tcp_data_snd_check(struct sock *sk) > static void __tcp_ack_snd_check(struct sock *sk, int ofo_possible) > { > struct tcp_sock *tp = tcp_sk(sk); > + const struct dst_entry *dst = __sk_dst_

[PATCH net-next] tcp: always send a quick ack when quickacks are enabled

2015-07-06 Thread Jon Maxwell
I ran some tests and after setting the "ip route change quickack 1" knob there were still many delayed ACKs sent. This occured because when icsk_ack.quick=0 the !icsk_ack.pingpong value is subsequently ignored as tcp_in_quickack_mode() checks both these values. The condition for a quick ack to