On 10/27/17 1:38 PM, Alban Crequy wrote:
Hi,
On 25 October 2017 at 01:57, Song Liu wrote:
This tracepoint can be used to trace synack retransmits. It maintains
pointer to struct request_sock.
We cannot simply reuse trace_tcp_retransmit_skb() here, because the
sk here is the LISTEN socket. The
Hi,
On 25 October 2017 at 01:57, Song Liu wrote:
> This tracepoint can be used to trace synack retransmits. It maintains
> pointer to struct request_sock.
>
> We cannot simply reuse trace_tcp_retransmit_skb() here, because the
> sk here is the LISTEN socket. The IP addresses and ports should be
>
On 10/26/17 10:06 PM, Song Liu wrote:
On Oct 26, 2017, at 7:01 PM, Cong Wang wrote:
On Thu, Oct 26, 2017 at 4:50 PM, Song Liu wrote:
In this case, we are putting CONFIG_IPV6 in TRACE_EVENT macro, which generates
warnings like:
./include/trace/events/tcp.h:274:1: error: directive in argumen
> On Oct 26, 2017, at 7:01 PM, Cong Wang wrote:
>
> On Thu, Oct 26, 2017 at 4:50 PM, Song Liu wrote:
>> In this case, we are putting CONFIG_IPV6 in TRACE_EVENT macro, which
>> generates
>> warnings like:
>>
>> ./include/trace/events/tcp.h:274:1: error: directive in argument list
>> ./include/
On Thu, Oct 26, 2017 at 4:50 PM, Song Liu wrote:
> In this case, we are putting CONFIG_IPV6 in TRACE_EVENT macro, which generates
> warnings like:
>
> ./include/trace/events/tcp.h:274:1: error: directive in argument list
> ./include/trace/events/tcp.h:281:1: error: directive in argument list
>
> S
> On Oct 25, 2017, at 8:13 PM, kbuild test robot wrote:
>
> Hi Song,
>
> [auto build test WARNING on net-next/master]
>
> url:
> https://github.com/0day-ci/linux/commits/Song-Liu/tcp-add-tracepoint-trace_tcp_retransmit_synack/20171026-010651
> reproduce:
># apt-get install sparse
>
Hi Song,
[auto build test WARNING on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Song-Liu/tcp-add-tracepoint-trace_tcp_retransmit_synack/20171026-010651
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
CCing key audience of the patch.
Thanks,
Song
> On Oct 24, 2017, at 4:57 PM, Song Liu wrote:
>
> This tracepoint can be used to trace synack retransmits. It maintains
> pointer to struct request_sock.
>
> We cannot simply reuse trace_tcp_retransmit_skb() here, because the
> sk here is the LIS
This tracepoint can be used to trace synack retransmits. It maintains
pointer to struct request_sock.
We cannot simply reuse trace_tcp_retransmit_skb() here, because the
sk here is the LISTEN socket. The IP addresses and ports should be
extracted from struct request_sock.
Signed-off-by: Song Liu
