> On Oct 26, 2017, at 7:01 PM, Cong Wang <xiyou.wangc...@gmail.com> wrote: > > On Thu, Oct 26, 2017 at 4:50 PM, Song Liu <songliubrav...@fb.com> wrote: >> In this case, we are putting CONFIG_IPV6 in TRACE_EVENT macro, which >> generates >> warnings like: >> >> ./include/trace/events/tcp.h:274:1: error: directive in argument list >> ./include/trace/events/tcp.h:281:1: error: directive in argument list >> >> Seems these warning cannot be easily avoided. This is also the same pattern >> we >> have been using in include/trace/events/tcp.h. > > Hmm, we use the same so why it only complains about this one?\
sparse reports same warning for all the lines in tcp.h. Don't know why kbuild test bot only complains about this patch. > >> >> Any suggestions on how shall we proceed from here? >> > > I think this warning is harmless, so perhaps not worthy time to > shut it up, unless sparse provides a simple way to do so.