Re: [PATCH net-next] selftests/net: fix bugs in cfg_port initialization

2017-12-25 Thread Sowmini Varadhan
On (12/25/17 15:49), Willem de Bruijn wrote: > > It would be good to also address the other instance of this at the > same time: protocol family (-4 or -6) has to be set before a call to > setup_sockaddr. Unlike this case, it hits an error() if called in the > "incorrect" order, but that is still

Re: [PATCH net-next] selftests/net: fix bugs in cfg_port initialization

2017-12-25 Thread Willem de Bruijn
On Sun, Dec 24, 2017 at 12:23 PM, Sowmini Varadhan wrote: > If -S is not used in the command line, we should > be binding to *.. Similarly, cfg_port should be > used to connect to the remote host even if it is processed > after -D. Thus we need to make sure that the cfg_port in > cfg_src_addr and

[PATCH net-next] selftests/net: fix bugs in cfg_port initialization

2017-12-24 Thread Sowmini Varadhan
If -S is not used in the command line, we should be binding to *.. Similarly, cfg_port should be used to connect to the remote host even if it is processed after -D. Thus we need to make sure that the cfg_port in cfg_src_addr and cfg_dst_addr are always initialized after all other command line opti