On (12/25/17 15:49), Willem de Bruijn wrote: > > It would be good to also address the other instance of this at the > same time: protocol family (-4 or -6) has to be set before a call to > setup_sockaddr. Unlike this case, it hits an error() if called in the > "incorrect" order, but that is still a crutch.
Yeah, I thought of that one too, but "usually" (at least that's what is instinctive to me) you bind to INADDR_ANY or ::, so this only becomes an issue on the client side. (And there, most people put the -4 or -6 before the address, but I agree it would be nice to fix this..) > But even better will be to save cfg_port, and src + dst addr optargs > as local variables, then call the init function only after parsing when > all state is available. Where this patch adds calls to > init_sockaddr_port, indeed. sure, I can put that out on V2 later this week.
