Re: [PATCH net-next] net: sched: alias action flags with TCA_ACT_ prefix

2020-11-24 Thread Vlad Buslov
On Tue 24 Nov 2020 at 18:24, Jakub Kicinski wrote: > On Tue, 24 Nov 2020 11:28:37 +0200 Vlad Buslov wrote: >> > TCA_FLAG_TERSE_DUMP exists only in net-next, we could rename it, right? >> >> You are right. I'll send a fix. > > You mean v2, not a follow up, right? :) Yes. Sending the v2.

Re: [PATCH net-next] net: sched: alias action flags with TCA_ACT_ prefix

2020-11-24 Thread Jakub Kicinski
On Tue, 24 Nov 2020 11:28:37 +0200 Vlad Buslov wrote: > > TCA_FLAG_TERSE_DUMP exists only in net-next, we could rename it, right? > > You are right. I'll send a fix. You mean v2, not a follow up, right? :)

Re: [PATCH net-next] net: sched: alias action flags with TCA_ACT_ prefix

2020-11-24 Thread Jamal Hadi Salim
On 2020-11-24 4:28 a.m., Vlad Buslov wrote: On Mon 23 Nov 2020 at 23:22, Jakub Kicinski wrote: On Sat, 21 Nov 2020 18:09:02 +0200 Vlad Buslov wrote: Currently both filter and action flags use same "TCA_" prefix which makes them hard to distinguish to code and confusing for users. Create aliase

Re: [PATCH net-next] net: sched: alias action flags with TCA_ACT_ prefix

2020-11-24 Thread Vlad Buslov
On Mon 23 Nov 2020 at 23:22, Jakub Kicinski wrote: > On Sat, 21 Nov 2020 18:09:02 +0200 Vlad Buslov wrote: >> Currently both filter and action flags use same "TCA_" prefix which makes >> them hard to distinguish to code and confusing for users. Create aliases >> for existing action flags constants

Re: [PATCH net-next] net: sched: alias action flags with TCA_ACT_ prefix

2020-11-23 Thread Jakub Kicinski
On Sat, 21 Nov 2020 18:09:02 +0200 Vlad Buslov wrote: > Currently both filter and action flags use same "TCA_" prefix which makes > them hard to distinguish to code and confusing for users. Create aliases > for existing action flags constants with "TCA_ACT_" prefix. > > Signed-off-by: Vlad Buslov

Re: [PATCH net-next] net: sched: alias action flags with TCA_ACT_ prefix

2020-11-22 Thread Jamal Hadi Salim
On 2020-11-21 11:09 a.m., Vlad Buslov wrote: Currently both filter and action flags use same "TCA_" prefix which makes them hard to distinguish to code and confusing for users. Create aliases for existing action flags constants with "TCA_ACT_" prefix. Signed-off-by: Vlad Buslov LGTM, thanks f

[PATCH net-next] net: sched: alias action flags with TCA_ACT_ prefix

2020-11-21 Thread Vlad Buslov
Currently both filter and action flags use same "TCA_" prefix which makes them hard to distinguish to code and confusing for users. Create aliases for existing action flags constants with "TCA_ACT_" prefix. Signed-off-by: Vlad Buslov --- include/uapi/linux/rtnetlink.h | 11 +++ net/sched