Re: [PATCH net-next] net: bcmgenet: add BQL support

2016-04-08 Thread Eric Dumazet
On Fri, 2016-04-08 at 21:13 -0700, Petri Gynther wrote: > What values does the networking core program into BQL dynamic limits > that my code in netdev->ndo_open() would wipe out? > 0 and 0 Clearing again these values by 0 and 0 is defensive programming. As I said, no BQL enabled driver does t

Re: [PATCH net-next] net: bcmgenet: add BQL support

2016-04-08 Thread Petri Gynther
On Fri, Apr 8, 2016 at 6:56 PM, Eric Dumazet wrote: > On Fri, 2016-04-08 at 18:39 -0700, Petri Gynther wrote: >> On Fri, Apr 8, 2016 at 1:36 PM, David Miller wrote: >> > From: Petri Gynther >> > Date: Tue, 5 Apr 2016 17:50:01 -0700 >> > >> >> Add Byte Queue Limits (BQL) support to bcmgenet driv

Re: [PATCH net-next] net: bcmgenet: add BQL support

2016-04-08 Thread Alexander Duyck
On Fri, Apr 8, 2016 at 6:56 PM, Eric Dumazet wrote: > On Fri, 2016-04-08 at 18:39 -0700, Petri Gynther wrote: >> On Fri, Apr 8, 2016 at 1:36 PM, David Miller wrote: >> > From: Petri Gynther >> > Date: Tue, 5 Apr 2016 17:50:01 -0700 >> > >> >> Add Byte Queue Limits (BQL) support to bcmgenet driv

Re: [PATCH net-next] net: bcmgenet: add BQL support

2016-04-08 Thread Eric Dumazet
On Fri, 2016-04-08 at 18:39 -0700, Petri Gynther wrote: > On Fri, Apr 8, 2016 at 1:36 PM, David Miller wrote: > > From: Petri Gynther > > Date: Tue, 5 Apr 2016 17:50:01 -0700 > > > >> Add Byte Queue Limits (BQL) support to bcmgenet driver. > >> > >> Signed-off-by: Petri Gynther > > > > As Eric

Re: [PATCH net-next] net: bcmgenet: add BQL support

2016-04-08 Thread Petri Gynther
On Fri, Apr 8, 2016 at 1:36 PM, David Miller wrote: > From: Petri Gynther > Date: Tue, 5 Apr 2016 17:50:01 -0700 > >> Add Byte Queue Limits (BQL) support to bcmgenet driver. >> >> Signed-off-by: Petri Gynther > > As Eric Dumazet indicated, your ->ndo_init() code to reset the queues is > probabl

Re: [PATCH net-next] net: bcmgenet: add BQL support

2016-04-08 Thread David Miller
From: Petri Gynther Date: Tue, 5 Apr 2016 17:50:01 -0700 > Add Byte Queue Limits (BQL) support to bcmgenet driver. > > Signed-off-by: Petri Gynther As Eric Dumazet indicated, your ->ndo_init() code to reset the queues is probably not necessary at all.

Re: [PATCH net-next] net: bcmgenet: add BQL support

2016-04-08 Thread Eric Dumazet
On Fri, 2016-04-08 at 09:54 -0700, Petri Gynther wrote: > On Wed, Apr 6, 2016 at 1:25 PM, Florian Fainelli wrote: > > > > 2016-04-05 17:50 GMT-07:00 Petri Gynther : > > > Add Byte Queue Limits (BQL) support to bcmgenet driver. > > > > > > Signed-off-by: Petri Gynther > > > > Signed-off-by: Floria

Re: [PATCH net-next] net: bcmgenet: add BQL support

2016-04-08 Thread Petri Gynther
On Wed, Apr 6, 2016 at 1:25 PM, Florian Fainelli wrote: > > 2016-04-05 17:50 GMT-07:00 Petri Gynther : > > Add Byte Queue Limits (BQL) support to bcmgenet driver. > > > > Signed-off-by: Petri Gynther > > Signed-off-by: Florian Fainelli > > Thanks! > -- > Florian Any further comments? Notable d

Re: [PATCH net-next] net: bcmgenet: add BQL support

2016-04-06 Thread Florian Fainelli
2016-04-05 17:50 GMT-07:00 Petri Gynther : > Add Byte Queue Limits (BQL) support to bcmgenet driver. > > Signed-off-by: Petri Gynther Signed-off-by: Florian Fainelli Thanks! -- Florian

[PATCH net-next] net: bcmgenet: add BQL support

2016-04-05 Thread Petri Gynther
Add Byte Queue Limits (BQL) support to bcmgenet driver. Signed-off-by: Petri Gynther --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broa