On Fri, 2016-04-08 at 09:54 -0700, Petri Gynther wrote: > On Wed, Apr 6, 2016 at 1:25 PM, Florian Fainelli <f.faine...@gmail.com> wrote: > > > > 2016-04-05 17:50 GMT-07:00 Petri Gynther <pgynt...@google.com>: > > > Add Byte Queue Limits (BQL) support to bcmgenet driver. > > > > > > Signed-off-by: Petri Gynther <pgynt...@google.com> > > > > Signed-off-by: Florian Fainelli <f.faine...@gmail.com> > > > > Thanks! > > -- > > Florian > > Any further comments? > > Notable difference from some other drivers -- > netdev_tx_reset_queue(txq) is called for all queues in > bcmgenet_netif_start(), just before netif_tx_start_all_queues(dev). > This is to ensure that BQL is reset before the interface becomes > operational. > > I think that is the right place for these calls. > > Some other drivers call it from the "interface down" path.
BQL is ready to go at device setup : __QUEUE_STATE_STACK_XOFF is not set dql_reset() was called from dql_init(), called from netdev_init_one_queue()
