Re: [PATCH net-next] neighbor: Add protocol attribute

2018-12-16 Thread David Miller
From: David Ahern Date: Sat, 15 Dec 2018 14:09:06 -0800 > From: David Ahern > > Similar to routes and rules, add protocol attribute to neighbor entries > for easier tracking of how each was created. > > Signed-off-by: David Ahern Applied, thanks David.

[PATCH net-next] neighbor: Add protocol attribute

2018-12-15 Thread David Ahern
From: David Ahern Similar to routes and rules, add protocol attribute to neighbor entries for easier tracking of how each was created. Signed-off-by: David Ahern --- include/net/neighbour.h| 2 ++ include/uapi/linux/neighbour.h | 1 + net/core/neighbour.c | 24 +

Re: [PATCH net-next] neighbor: Add protocol attribute

2018-12-14 Thread David Miller
From: David Ahern Date: Tue, 11 Dec 2018 08:22:04 -0700 > On 12/10/18 10:59 PM, David Miller wrote: >> From: David Ahern >> Date: Mon, 10 Dec 2018 19:47:33 -0700 >> >>> On 12/7/18 4:45 PM, David Miller wrote: Right, neigh->ha[] should probably be kept 8-byte aligned. >>> >>> From

Re: [PATCH net-next] neighbor: Add protocol attribute

2018-12-11 Thread David Ahern
On 12/10/18 10:59 PM, David Miller wrote: > From: David Ahern > Date: Mon, 10 Dec 2018 19:47:33 -0700 > >> On 12/7/18 4:45 PM, David Miller wrote: >>> >>> Right, neigh->ha[] should probably be kept 8-byte aligned. >>> >> >> From what I can see ha is only used with memcpy, and neighbour struct is

Re: [PATCH net-next] neighbor: Add protocol attribute

2018-12-10 Thread David Miller
From: David Ahern Date: Mon, 10 Dec 2018 19:47:33 -0700 > On 12/7/18 4:45 PM, David Miller wrote: >> >> Right, neigh->ha[] should probably be kept 8-byte aligned. >> > > From what I can see ha is only used with memcpy, and neighbour struct is > annotated with __randomize_layout. Are you saying

Re: [PATCH net-next] neighbor: Add protocol attribute

2018-12-10 Thread David Ahern
On 12/7/18 4:45 PM, David Miller wrote: > > Right, neigh->ha[] should probably be kept 8-byte aligned. > >From what I can see ha is only used with memcpy, and neighbour struct is annotated with __randomize_layout. Are you saying that ha should be marked with __aligned(8)? @@ -150,7 +150,7 @@ s

Re: [PATCH net-next] neighbor: Add protocol attribute

2018-12-07 Thread David Miller
From: Eric Dumazet Date: Fri, 7 Dec 2018 15:03:04 -0800 > On 12/07/2018 02:24 PM, David Ahern wrote: >> On 12/7/18 3:20 PM, Eric Dumazet wrote: >> >> /* --- cacheline 3 boundary (192 bytes) --- */ >> struct hh_cachehh; /* 19248 */ >> >> ... >> >> but does no

Re: [PATCH net-next] neighbor: Add protocol attribute

2018-12-07 Thread Eric Dumazet
On 12/07/2018 02:24 PM, David Ahern wrote: > On 12/7/18 3:20 PM, Eric Dumazet wrote: >> >> >> On 12/07/2018 01:49 PM, David Ahern wrote: >>> From: David Ahern >>> >>> Similar to routes and rules, add protocol attribute to neighbor entries >>> for easier tracking of how each was created. >>> >>>

Re: [PATCH net-next] neighbor: Add protocol attribute

2018-12-07 Thread David Ahern
On 12/7/18 3:20 PM, Eric Dumazet wrote: > > > On 12/07/2018 01:49 PM, David Ahern wrote: >> From: David Ahern >> >> Similar to routes and rules, add protocol attribute to neighbor entries >> for easier tracking of how each was created. >> >> Signed-off-by: David Ahern >> --- >> include/net/nei

Re: [PATCH net-next] neighbor: Add protocol attribute

2018-12-07 Thread Eric Dumazet
On 12/07/2018 01:49 PM, David Ahern wrote: > From: David Ahern > > Similar to routes and rules, add protocol attribute to neighbor entries > for easier tracking of how each was created. > > Signed-off-by: David Ahern > --- > include/net/neighbour.h| 2 ++ > include/uapi/linux/neigh

[PATCH net-next] neighbor: Add protocol attribute

2018-12-07 Thread David Ahern
From: David Ahern Similar to routes and rules, add protocol attribute to neighbor entries for easier tracking of how each was created. Signed-off-by: David Ahern --- include/net/neighbour.h| 2 ++ include/uapi/linux/neighbour.h | 1 + net/core/neighbour.c | 24 +