From: David Ahern <dsah...@gmail.com> Date: Mon, 10 Dec 2018 19:47:33 -0700
> On 12/7/18 4:45 PM, David Miller wrote: >> >> Right, neigh->ha[] should probably be kept 8-byte aligned. >> > > From what I can see ha is only used with memcpy, and neighbour struct is > annotated with __randomize_layout. Are you saying that ha should be > marked with __aligned(8)? People who care about performance probably don't build with randomization enabled, do they? Even though it uses memcpy() it will be faster if it is 8 byte aligned and we can probably explicitly take advantage of that alignment even more if we add the marking as you suggest perhaps. Given all of this, what is your opinion?
