Re: [PATCH net-next] mpls: allow TTL propagation to/from IP packets to be configured

2017-02-02 Thread David Ahern
On 2/2/17 8:21 PM, Eric W. Biederman wrote: > > My brain is mostly elswhere right now so I don't have an implementation > on how it should be implemented. However Linux fundamentally gets used > interesting ways, and if we don't implement the option as per mpls exit > now someone will come along

Re: [PATCH net-next] mpls: allow TTL propagation to/from IP packets to be configured

2017-02-02 Thread Eric W. Biederman
Robert Shearman writes: > On 31/01/17 00:17, Eric W. Biederman wrote: >> Robert Shearman writes: >> >>> It is sometimes desirable to present an MPLS transport network as a >>> single hop to traffic transiting it because it prevents confusion when >>> diagnosing failures. An example of where conf

Re: [PATCH net-next] mpls: allow TTL propagation to/from IP packets to be configured

2017-01-31 Thread Robert Shearman
On 31/01/17 01:09, David Ahern wrote: On 1/30/17 1:36 PM, Robert Shearman wrote: @@ -243,24 +245,29 @@ static bool mpls_egress(struct mpls_route *rt, struct sk_buff *skb, payload_type = ip_hdr(skb)->version; switch (payload_type) { - case MPT_IPV4: { -

Re: [PATCH net-next] mpls: allow TTL propagation to/from IP packets to be configured

2017-01-31 Thread Robert Shearman
On 31/01/17 00:41, David Ahern wrote: On 1/30/17 1:36 PM, Robert Shearman wrote: It is sometimes desirable to present an MPLS transport network as a single hop to traffic transiting it because it prevents confusion when diagnosing failures. An example of where confusion can be generated is when

Re: [PATCH net-next] mpls: allow TTL propagation to/from IP packets to be configured

2017-01-31 Thread Robert Shearman
On 31/01/17 00:17, Eric W. Biederman wrote: Robert Shearman writes: It is sometimes desirable to present an MPLS transport network as a single hop to traffic transiting it because it prevents confusion when diagnosing failures. An example of where confusion can be generated is when addresses u

Re: [PATCH net-next] mpls: allow TTL propagation to/from IP packets to be configured

2017-01-30 Thread David Ahern
On 1/30/17 1:36 PM, Robert Shearman wrote: > @@ -243,24 +245,29 @@ static bool mpls_egress(struct mpls_route *rt, struct > sk_buff *skb, > payload_type = ip_hdr(skb)->version; > > switch (payload_type) { > - case MPT_IPV4: { > - struct iphdr *hdr4 = ip_hdr(skb

Re: [PATCH net-next] mpls: allow TTL propagation to/from IP packets to be configured

2017-01-30 Thread David Ahern
On 1/30/17 1:36 PM, Robert Shearman wrote: > It is sometimes desirable to present an MPLS transport network as a > single hop to traffic transiting it because it prevents confusion when > diagnosing failures. An example of where confusion can be generated is > when addresses used in the provider ne

Re: [PATCH net-next] mpls: allow TTL propagation to/from IP packets to be configured

2017-01-30 Thread Eric W. Biederman
Robert Shearman writes: > It is sometimes desirable to present an MPLS transport network as a > single hop to traffic transiting it because it prevents confusion when > diagnosing failures. An example of where confusion can be generated is > when addresses used in the provider network overlap wit

[PATCH net-next] mpls: allow TTL propagation to/from IP packets to be configured

2017-01-30 Thread Robert Shearman
It is sometimes desirable to present an MPLS transport network as a single hop to traffic transiting it because it prevents confusion when diagnosing failures. An example of where confusion can be generated is when addresses used in the provider network overlap with addresses in the overlay network