On 2/2/17 8:21 PM, Eric W. Biederman wrote:
> 
> My brain is mostly elswhere right now so I don't have an implementation
> on how it should be implemented.   However Linux fundamentally gets used
> interesting ways, and if we don't implement the option as per mpls exit
> now someone will come along and need to do the work later.
> 
> Perhaps it will only be used with hard coded static configurations, and
> it is fundamentally a per tunnel property.
> 
> It will be less work to maintain, and the code will run faster in the
> long run if we don't have two code paths to maintain.

I can see the argument for per-tunnel knobs, but looking at ios and nx-os docs 
it seems appropriate to have a global knob as well. In that regards having 
sysctl knobs solves the global setting and when/if needed we can add 
MPLS_IPTUNNEL_ZZZZZ encap attributes for the per-tunnel settings.

Does that seem reasonable?

Reply via email to