Re: [PATCH net-next] macvlan: fix failure during registration v2

2016-04-22 Thread Eric W. Biederman
Francesco Ruggeri writes: > On Thu, Apr 21, 2016 at 10:44 AM, Eric W. Biederman > wrote: > < >>> diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c >>> index 95394ed..e770221 100644 >>> --- a/drivers/net/macvtap.c >>> +++ b/drivers/net/macvtap.c >>> @@ -1303,6 +1303,8 @@ static int macvt

Re: [PATCH net-next] macvlan: fix failure during registration v2

2016-04-21 Thread Francesco Ruggeri
On Thu, Apr 21, 2016 at 10:44 AM, Eric W. Biederman wrote: < >> diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c >> index 95394ed..e770221 100644 >> --- a/drivers/net/macvtap.c >> +++ b/drivers/net/macvtap.c >> @@ -1303,6 +1303,8 @@ static int macvtap_device_event(struct notifier_block

Re: [PATCH net-next] macvlan: fix failure during registration v2

2016-04-21 Thread Eric W. Biederman
Francesco Ruggeri writes: > If macvlan_common_newlink fails in register_netdevice after macvlan_init > then it decrements port->count twice, first in macvlan_uninit (from > register_netdevice or rollback_registered) and then again in > macvlan_common_newlink. > A similar problem may exist in the

[PATCH net-next] macvlan: fix failure during registration v2

2016-04-20 Thread Francesco Ruggeri
If macvlan_common_newlink fails in register_netdevice after macvlan_init then it decrements port->count twice, first in macvlan_uninit (from register_netdevice or rollback_registered) and then again in macvlan_common_newlink. A similar problem may exist in the ipvlan driver. This patch consolidates