Re: [PATCH net-next] drivers/net/wan/hdlc_fr: Improvements to the code of pvc_xmit

2020-10-04 Thread David Miller
From: Xie He Date: Sat, 3 Oct 2020 15:41:05 -0700 > 1. Keep the code for the normal (non-error) flow at the lowest > indentation level. And use "goto drop" for all error handling. > > 2. Replace code that pads short Ethernet frames with a "__skb_pad" call. > > 3. Change "dev_kfree_skb" to "kfr

[PATCH net-next] drivers/net/wan/hdlc_fr: Improvements to the code of pvc_xmit

2020-10-03 Thread Xie He
1. Keep the code for the normal (non-error) flow at the lowest indentation level. And use "goto drop" for all error handling. 2. Replace code that pads short Ethernet frames with a "__skb_pad" call. 3. Change "dev_kfree_skb" to "kfree_skb" in error handling code. "kfree_skb" is the correct functi