Re: [PATCH net] soreuseport: use RCU_INIT_POINTER() when NULLing

2018-12-12 Thread Xiaozhou Liu
On Wed, Dec 12, 2018 at 05:08:45AM -0800, Eric Dumazet wrote: > > It is _not_ faster. > > Just different ways to do the exact same thing. > > For some reason you missed this two years old commit : > > > commit 3a37f7275cda5ad25c1fe9be8f20c76c60d175fa > Author: Paul E. McKenney > Date: Sun

Re: [PATCH net] soreuseport: use RCU_INIT_POINTER() when NULLing

2018-12-12 Thread Eric Dumazet
On 12/12/2018 01:58 AM, Xiaozhou Liu wrote: > Use RCU_INIT_POINTER() instead of rcu_assign_pointer() to > NULL out the pointer because it is a bit faster. > > Signed-off-by: Xiaozhou Liu > --- > net/core/sock_reuseport.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[PATCH net] soreuseport: use RCU_INIT_POINTER() when NULLing

2018-12-12 Thread Xiaozhou Liu
Use RCU_INIT_POINTER() instead of rcu_assign_pointer() to NULL out the pointer because it is a bit faster. Signed-off-by: Xiaozhou Liu --- net/core/sock_reuseport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/sock_reuseport.c b/net/core/sock_reuseport.c index d8f