On Wed, Dec 12, 2018 at 05:08:45AM -0800, Eric Dumazet wrote:

> 
> It is _not_ faster.
> 
> Just different ways to do the exact same thing.
> 
> For some reason you missed this two years old commit :
> 
> 
> commit 3a37f7275cda5ad25c1fe9be8f20c76c60d175fa
> Author: Paul E. McKenney <paul...@linux.vnet.ibm.com>
> Date:   Sun May 1 18:46:54 2016 -0700
> 
>     rcu: No ordering for rcu_assign_pointer() of NULL
>     
>     This commit does a compile-time check for rcu_assign_pointer() of NULL,
>     and uses WRITE_ONCE() rather than smp_store_release() in that case.
>     
>     Reported-by: Christoph Hellwig <h...@infradead.org>
>     Signed-off-by: Paul E. McKenney <paul...@linux.vnet.ibm.com>

Thanks for pointing this out. I guess the comments in include/linux/rcupdate.h
may need some updating.


Xiaozhou

Reply via email to