Re: [PATCH net] r8169: fix operation under forced interrupt threading

2020-10-29 Thread Thomas Gleixner
On Thu, Oct 29 2020 at 11:19, Heiner Kallweit wrote: > On 29.10.2020 10:42, Thomas Gleixner wrote: > Correct, just that the legacy PCI interrupt scenario doesn't affect old > systems/devices only. Users may run the system with nomsi for > whatever reason and we need to be prepared. > > We could add

Re: [PATCH net] r8169: fix operation under forced interrupt threading

2020-10-29 Thread Heiner Kallweit
On 29.10.2020 10:42, Thomas Gleixner wrote: > On Thu, Oct 29 2020 at 09:42, Heiner Kallweit wrote: >> On 29.10.2020 00:29, Jakub Kicinski wrote: >>> Other handles may take spin_locks, which will sleep on RT. >>> >>> I guess we may need to switch away from the _irqoff() variant for >>> drivers with

Re: [PATCH net] r8169: fix operation under forced interrupt threading

2020-10-29 Thread Thomas Gleixner
On Thu, Oct 29 2020 at 09:42, Heiner Kallweit wrote: > On 29.10.2020 00:29, Jakub Kicinski wrote: >> Other handles may take spin_locks, which will sleep on RT. >> >> I guess we may need to switch away from the _irqoff() variant for >> drivers with IRQF_SHARED after all :( >> > Right. Unfortunatel

Re: [PATCH net] r8169: fix operation under forced interrupt threading

2020-10-29 Thread Heiner Kallweit
On 29.10.2020 00:29, Jakub Kicinski wrote: > On Wed, 28 Oct 2020 13:17:58 +0100 Heiner Kallweit wrote: >> On 28.10.2020 12:43, Serge Belyshev wrote: For several network drivers it was reported that using __napi_schedule_irqoff() is unsafe with forced threading. One way to fix this is

Re: [PATCH net] r8169: fix operation under forced interrupt threading

2020-10-28 Thread Jakub Kicinski
On Wed, 28 Oct 2020 13:17:58 +0100 Heiner Kallweit wrote: > On 28.10.2020 12:43, Serge Belyshev wrote: > >> For several network drivers it was reported that using > >> __napi_schedule_irqoff() is unsafe with forced threading. One way to > >> fix this is switching back to __napi_schedule, but then w

Re: [PATCH net] r8169: fix operation under forced interrupt threading

2020-10-28 Thread Heiner Kallweit
On 28.10.2020 12:43, Serge Belyshev wrote: > >> For several network drivers it was reported that using >> __napi_schedule_irqoff() is unsafe with forced threading. One way to >> fix this is switching back to __napi_schedule, but then we lose the >> benefit of the irqoff version in general. As stat

Re: [PATCH net] r8169: fix operation under forced interrupt threading

2020-10-28 Thread Heiner Kallweit
On 28.10.2020 12:43, Serge Belyshev wrote: > >> For several network drivers it was reported that using >> __napi_schedule_irqoff() is unsafe with forced threading. One way to >> fix this is switching back to __napi_schedule, but then we lose the >> benefit of the irqoff version in general. As stat

Re: [PATCH net] r8169: fix operation under forced interrupt threading

2020-10-28 Thread Serge Belyshev
>> [8.850099] genirq: Flags mismatch irq 18. 00010080 (eth0) vs. 2080 >> (ahci[:05:00.0]) >> > Please provide the following info in addition: > - dmesg > - lspci -v > - cat /proc/interrupts Attached below. [0.00] Linux version 5.9.0-10641-g424a646e072a (ssb@spider) (gcc 4.

Re: [PATCH net] r8169: fix operation under forced interrupt threading

2020-10-28 Thread Serge Belyshev
> For several network drivers it was reported that using > __napi_schedule_irqoff() is unsafe with forced threading. One way to > fix this is switching back to __napi_schedule, but then we lose the > benefit of the irqoff version in general. As stated by Eric it doesn't > make sense to make the m

Re: [PATCH net] r8169: fix operation under forced interrupt threading

2020-10-28 Thread Thomas Gleixner
On Wed, Oct 28 2020 at 13:17, Heiner Kallweit wrote: > On 28.10.2020 12:43, Serge Belyshev wrote: >>> For several network drivers it was reported that using >>> __napi_schedule_irqoff() is unsafe with forced threading. One way to >>> fix this is switching back to __napi_schedule, but then we lose t

Re: [PATCH net] r8169: fix operation under forced interrupt threading

2020-10-19 Thread Jakub Kicinski
On Sun, 18 Oct 2020 18:38:59 +0200 Heiner Kallweit wrote: > For several network drivers it was reported that using > __napi_schedule_irqoff() is unsafe with forced threading. One way to > fix this is switching back to __napi_schedule, but then we lose the > benefit of the irqoff version in general.

[PATCH net] r8169: fix operation under forced interrupt threading

2020-10-18 Thread Heiner Kallweit
For several network drivers it was reported that using __napi_schedule_irqoff() is unsafe with forced threading. One way to fix this is switching back to __napi_schedule, but then we lose the benefit of the irqoff version in general. As stated by Eric it doesn't make sense to make the minimal hard