Re: [PATCH net] net: diag: document swapped src/dst in udp_dump_one.

2018-10-28 Thread David Miller
From: Lorenzo Colitti Date: Mon, 29 Oct 2018 09:15:22 +0900 > Since its inception, udp_dump_one has had a bug where userspace > needs to swap src and dst addresses and ports in order to find > the socket it wants. This is because it passes the socket source > address to __udp[46]_lib_lookup's sad

[PATCH net] net: diag: document swapped src/dst in udp_dump_one.

2018-10-28 Thread Lorenzo Colitti
Since its inception, udp_dump_one has had a bug where userspace needs to swap src and dst addresses and ports in order to find the socket it wants. This is because it passes the socket source address to __udp[46]_lib_lookup's saddr argument, but those functions are intended to find local sockets ma