From: Lorenzo Colitti <lore...@google.com>
Date: Mon, 29 Oct 2018 09:15:22 +0900
> Since its inception, udp_dump_one has had a bug where userspace
> needs to swap src and dst addresses and ports in order to find
> the socket it wants. This is because it passes the socket source
> address to __udp[46]_lib_lookup's saddr argument, but those
> functions are intended to find local sockets matching received
> packets, so saddr is the remote address, not the local address.
>
> This can no longer be fixed for backwards compatibility reasons,
> so add a brief comment explaining that this is the case. This
> will avoid confusion and help ensure SOCK_DIAG implementations
> of new protocols don't have the same problem.
>
> Fixes: a925aa00a55 ("udp_diag: Implement the get_exact dumping functionality")
> Signed-off-by: Lorenzo Colitti <lore...@google.com>
Applied, thanks.
