Re: [PATCH net] l2tp: fix missing print session offset info

2017-12-21 Thread Hangbin Liu
On Thu, Dec 21, 2017 at 03:08:36PM -0500, David Miller wrote: > From: Hangbin Liu > Date: Thu, 21 Dec 2017 14:45:30 +0800 > > > + (session->offset && > > +nla_put_u16(skb, L2TP_ATTR_OFFSET, session->offset) || > > It really discourages people from reviewing your changes when they >

Re: [PATCH net] l2tp: fix missing print session offset info

2017-12-21 Thread David Miller
From: Hangbin Liu Date: Thu, 21 Dec 2017 14:45:30 +0800 > + (session->offset && > + nla_put_u16(skb, L2TP_ATTR_OFFSET, session->offset) || It really discourages people from reviewing your changes when they don't even compile. net/l2tp/l2tp_netlink.c: In function ‘l2tp_nl_sessio

[PATCH net] l2tp: fix missing print session offset info

2017-12-20 Thread Hangbin Liu
Fixes: 309795f4bec ("l2tp: Add netlink control API for L2TP") Reported-by: Jianlin Shi Signed-off-by: Hangbin Liu --- net/l2tp/l2tp_netlink.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/l2tp/l2tp_netlink.c b/net/l2tp/l2tp_netlink.c index a1f24fb..36378b4 100644 --- a/net/l2tp/l2tp_