From: Hangbin Liu <[email protected]>
Date: Thu, 21 Dec 2017 14:45:30 +0800
> + (session->offset &&
> + nla_put_u16(skb, L2TP_ATTR_OFFSET, session->offset) ||
It really discourages people from reviewing your changes when they
don't even compile.
net/l2tp/l2tp_netlink.c: In function ‘l2tp_nl_session_send’:
net/l2tp/l2tp_netlink.c:764:23: warning: suggest parentheses around ‘&&’ within
‘||’ [-Wparentheses]
(session->offset &&
~~~~~~~~~~~~~~~~^~
nla_put_u16(skb, L2TP_ATTR_OFFSET, session->offset) ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
net/l2tp/l2tp_netlink.c:782:3: error: expected ‘)’ before ‘goto’
goto nla_put_failure;
^~~~
...
