Re: [PATCH net] devlink: Fix error handling in param and info_get dumpit cb

2019-09-27 Thread Vasundhara Volam
On Fri, Sep 27, 2019 at 6:01 PM Andrew Lunn wrote: > > On Fri, Sep 27, 2019 at 10:28:36AM +0530, Vasundhara Volam wrote: > > On Thu, Sep 26, 2019 at 5:57 PM Andrew Lunn wrote: > > > > > > On Thu, Sep 26, 2019 at 03:05:54PM +0530, Vasundhara Volam wrote: > > > > If any of the param or info_get op

Re: [PATCH net] devlink: Fix error handling in param and info_get dumpit cb

2019-09-27 Thread Jiri Pirko
Fri, Sep 27, 2019 at 02:31:29PM CEST, and...@lunn.ch wrote: >On Fri, Sep 27, 2019 at 10:28:36AM +0530, Vasundhara Volam wrote: >> On Thu, Sep 26, 2019 at 5:57 PM Andrew Lunn wrote: >> > >> > On Thu, Sep 26, 2019 at 03:05:54PM +0530, Vasundhara Volam wrote: >> > > If any of the param or info_get op

Re: [PATCH net] devlink: Fix error handling in param and info_get dumpit cb

2019-09-27 Thread Andrew Lunn
On Fri, Sep 27, 2019 at 10:28:36AM +0530, Vasundhara Volam wrote: > On Thu, Sep 26, 2019 at 5:57 PM Andrew Lunn wrote: > > > > On Thu, Sep 26, 2019 at 03:05:54PM +0530, Vasundhara Volam wrote: > > > If any of the param or info_get op returns error, dumpit cb is > > > skipping to dump remaining par

Re: [PATCH net] devlink: Fix error handling in param and info_get dumpit cb

2019-09-26 Thread Vasundhara Volam
On Thu, Sep 26, 2019 at 5:57 PM Andrew Lunn wrote: > > On Thu, Sep 26, 2019 at 03:05:54PM +0530, Vasundhara Volam wrote: > > If any of the param or info_get op returns error, dumpit cb is > > skipping to dump remaining params or info_get ops for all the > > drivers. > > > > Instead skip only for t

Re: [PATCH net] devlink: Fix error handling in param and info_get dumpit cb

2019-09-26 Thread Andrew Lunn
On Thu, Sep 26, 2019 at 03:05:54PM +0530, Vasundhara Volam wrote: > If any of the param or info_get op returns error, dumpit cb is > skipping to dump remaining params or info_get ops for all the > drivers. > > Instead skip only for the param/info_get op which returned error > and continue to dump

[PATCH net] devlink: Fix error handling in param and info_get dumpit cb

2019-09-26 Thread Vasundhara Volam
If any of the param or info_get op returns error, dumpit cb is skipping to dump remaining params or info_get ops for all the drivers. Instead skip only for the param/info_get op which returned error and continue to dump remaining information, except if the return code is EMSGSIZE. Cc: Jiri Pirko