Fri, Sep 27, 2019 at 02:31:29PM CEST, and...@lunn.ch wrote: >On Fri, Sep 27, 2019 at 10:28:36AM +0530, Vasundhara Volam wrote: >> On Thu, Sep 26, 2019 at 5:57 PM Andrew Lunn <and...@lunn.ch> wrote: >> > >> > On Thu, Sep 26, 2019 at 03:05:54PM +0530, Vasundhara Volam wrote: >> > > If any of the param or info_get op returns error, dumpit cb is >> > > skipping to dump remaining params or info_get ops for all the >> > > drivers. >> > > >> > > Instead skip only for the param/info_get op which returned error >> > > and continue to dump remaining information, except if the return >> > > code is EMSGSIZE. >> > >> > Hi Vasundhara >> > >> > How do we get to see something did fail? If it failed, it failed for a >> > reason, and we want to know. >> > >> > What is your real use case here? What is failing, and why are you >> > O.K. to skip this failure? >> > >> > Andrew >> Hi Andrew, >> >> Thank you for looking into the patch. >> >> If any of the devlink parameter is returning error like EINVAL, then >> current code is not displaying any further parameters for all the other >> devices as well. >> >> In bnxt_en driver case, some of the parameters are not supported in >> certain configurations like if the parameter is not part of the >> NVM configuration, driver returns EINVAL error to the stack. And devlink is >> skipping to display all the remaining parameters for that device and others >> as well. >> >> I am trying to fix to skip only the error parameter and display the remaining >> parameters. > >Hi Vasundhara > >Thanks for explaining your use case. It sounds sensible. But i would >narrow this down. > >Make the driver return EOPNOTSUP, not EINVAL. And then in dump, only >skip EOPNOTSUP. Any other errors cause the error to be returned, so we >get to see them.
Agreed, that would be more reasonable. > > Andrew
