Re: [PATCH net] bpf: enforce correct alignment for instructions

2018-06-21 Thread David Miller
From: Daniel Borkmann Date: Thu, 21 Jun 2018 23:03:09 +0200 > On 06/21/2018 06:08 AM, Eric Dumazet wrote: >> On 06/20/2018 08:46 PM, David Miller wrote: >>> From: Eric Dumazet >>> Date: Wed, 20 Jun 2018 17:24:09 -0700 >>> After commit 9facc336876f ("bpf: reject any prog that failed read-onl

Re: [PATCH net] bpf: enforce correct alignment for instructions

2018-06-21 Thread Daniel Borkmann
On 06/21/2018 06:08 AM, Eric Dumazet wrote: > On 06/20/2018 08:46 PM, David Miller wrote: >> From: Eric Dumazet >> Date: Wed, 20 Jun 2018 17:24:09 -0700 >> >>> After commit 9facc336876f ("bpf: reject any prog that failed read-only >>> lock") >>> offsetof(struct bpf_binary_header, image) became 3

Re: [PATCH net] bpf: enforce correct alignment for instructions

2018-06-20 Thread Eric Dumazet
On 06/20/2018 08:46 PM, David Miller wrote: > From: Eric Dumazet > Date: Wed, 20 Jun 2018 17:24:09 -0700 > >> After commit 9facc336876f ("bpf: reject any prog that failed read-only lock") >> offsetof(struct bpf_binary_header, image) became 3 instead of 4, >> breaking powerpc BPF badly, since i

Re: [PATCH net] bpf: enforce correct alignment for instructions

2018-06-20 Thread David Miller
From: Eric Dumazet Date: Wed, 20 Jun 2018 17:24:09 -0700 > After commit 9facc336876f ("bpf: reject any prog that failed read-only lock") > offsetof(struct bpf_binary_header, image) became 3 instead of 4, > breaking powerpc BPF badly, since instructions need to be word aligned. > > Fixes: 9facc33

[PATCH net] bpf: enforce correct alignment for instructions

2018-06-20 Thread Eric Dumazet
After commit 9facc336876f ("bpf: reject any prog that failed read-only lock") offsetof(struct bpf_binary_header, image) became 3 instead of 4, breaking powerpc BPF badly, since instructions need to be word aligned. Fixes: 9facc336876f ("bpf: reject any prog that failed read-only lock") Signed-off-