Re: [PATCH net] amd-xgbe: Use wmb before updating current descriptor count

2015-10-23 Thread David Miller
From: Tom Lendacky Date: Fri, 23 Oct 2015 11:57:27 -0500 > David, if this is indeed the proper fix would you want to me to send a > new patch based on this old patch or a new patch based on you having > reverted the old patch? One never sends me a "new patch" for a patch I've already applied, on

Re: [PATCH net] amd-xgbe: Use wmb before updating current descriptor count

2015-10-23 Thread Tom Lendacky
On 10/23/2015 11:29 AM, Alexander Duyck wrote: On 10/21/2015 01:37 PM, Tom Lendacky wrote: The code currently uses the lightweight dma_wmb barrier before updating the current descriptor count. Under heavy load, the Tx cleanup routine was seeing the updated current descriptor count before the upd

Re: [PATCH net] amd-xgbe: Use wmb before updating current descriptor count

2015-10-23 Thread Alexander Duyck
On 10/21/2015 01:37 PM, Tom Lendacky wrote: The code currently uses the lightweight dma_wmb barrier before updating the current descriptor count. Under heavy load, the Tx cleanup routine was seeing the updated current descriptor count before the updated descriptor information. As a result, the Tx

Re: [PATCH net] amd-xgbe: Use wmb before updating current descriptor count

2015-10-23 Thread David Miller
From: Tom Lendacky Date: Fri, 23 Oct 2015 08:35:52 -0500 > Can you queue this up for stable? It is applicable to 4.1 and 4.2. Ok, done. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.

Re: [PATCH net] amd-xgbe: Use wmb before updating current descriptor count

2015-10-23 Thread Tom Lendacky
On 10/23/2015 04:59 AM, David Miller wrote: From: Tom Lendacky Date: Wed, 21 Oct 2015 15:37:05 -0500 The code currently uses the lightweight dma_wmb barrier before updating the current descriptor count. Under heavy load, the Tx cleanup routine was seeing the updated current descriptor count be

Re: [PATCH net] amd-xgbe: Use wmb before updating current descriptor count

2015-10-23 Thread David Miller
From: Tom Lendacky Date: Wed, 21 Oct 2015 15:37:05 -0500 > The code currently uses the lightweight dma_wmb barrier before updating > the current descriptor count. Under heavy load, the Tx cleanup routine > was seeing the updated current descriptor count before the updated > descriptor information

[PATCH net] amd-xgbe: Use wmb before updating current descriptor count

2015-10-21 Thread Tom Lendacky
The code currently uses the lightweight dma_wmb barrier before updating the current descriptor count. Under heavy load, the Tx cleanup routine was seeing the updated current descriptor count before the updated descriptor information. As a result, the Tx descriptor was being cleaned up before it was