Re: [PATCH net] amd-xgbe: Enable IRQs only if napi_complete_done() is true

2017-03-10 Thread David Miller
From: Tom Lendacky Date: Fri, 10 Mar 2017 08:19:37 -0600 > On 3/9/2017 8:31 PM, David Miller wrote: >> From: Tom Lendacky >> Date: Thu, 9 Mar 2017 17:48:23 -0600 >> >>> Depending on the hardware, the amd-xgbe driver may use >>> disable_irq_nosync() >>> and enable_irq() when an interrupt is recei

Re: [PATCH net] amd-xgbe: Enable IRQs only if napi_complete_done() is true

2017-03-10 Thread Jeremy Linton
On 03/09/2017 05:48 PM, Tom Lendacky wrote: Depending on the hardware, the amd-xgbe driver may use disable_irq_nosync() and enable_irq() when an interrupt is received to process Rx packets. If the napi_complete_done() return value isn't checked an unbalanced enable for the IRQ could result, gener

Re: [PATCH net] amd-xgbe: Enable IRQs only if napi_complete_done() is true

2017-03-10 Thread Tom Lendacky
On 3/9/2017 8:31 PM, David Miller wrote: From: Tom Lendacky Date: Thu, 9 Mar 2017 17:48:23 -0600 Depending on the hardware, the amd-xgbe driver may use disable_irq_nosync() and enable_irq() when an interrupt is received to process Rx packets. If the napi_complete_done() return value isn't chec

Re: [PATCH net] amd-xgbe: Enable IRQs only if napi_complete_done() is true

2017-03-09 Thread David Miller
From: Tom Lendacky Date: Thu, 9 Mar 2017 17:48:23 -0600 > Depending on the hardware, the amd-xgbe driver may use disable_irq_nosync() > and enable_irq() when an interrupt is received to process Rx packets. If > the napi_complete_done() return value isn't checked an unbalanced enable > for the IRQ

[PATCH net] amd-xgbe: Enable IRQs only if napi_complete_done() is true

2017-03-09 Thread Tom Lendacky
Depending on the hardware, the amd-xgbe driver may use disable_irq_nosync() and enable_irq() when an interrupt is received to process Rx packets. If the napi_complete_done() return value isn't checked an unbalanced enable for the IRQ could result, generating a warning stack trace. Update the drive