Re: [PATCH iproute2 v3 5/5] ip: add MACsec support

2016-05-24 Thread Sabrina Dubroca
Hello Stephen, 2016-05-23, 16:21:42 -0700, Stephen Hemminger wrote: > On Wed, 18 May 2016 17:35:13 +0200 > Sabrina Dubroca wrote: > > > + > > +static void print_rx_sc(const char *prefix, __u64 sci, __u8 active, struct > > rtattr *rxsc_stats, struct rtattr *sa) > > +{ > > Overall, this looks fi

Re: [PATCH iproute2 v3 5/5] ip: add MACsec support

2016-05-23 Thread Stephen Hemminger
On Wed, 18 May 2016 17:35:13 +0200 Sabrina Dubroca wrote: > + > +static void print_rx_sc(const char *prefix, __u64 sci, __u8 active, struct > rtattr *rxsc_stats, struct rtattr *sa) > +{ Overall, this looks fine, but could you break some of the really long lines. In general, I like iproute2 to f

[PATCH iproute2 v3 5/5] ip: add MACsec support

2016-05-18 Thread Sabrina Dubroca
Extend ip-link to create MACsec devices ip link add link type macsec [options] Add `ip macsec` command to configure receive-side secure channels and secure associations within a macsec netdevice. Signed-off-by: Sabrina Dubroca Acked-by: Phil Sutter --- Changes since v1: - use new utils -