On Wed, 18 May 2016 17:35:13 +0200 Sabrina Dubroca <s...@queasysnail.net> wrote:
> + > +static void print_rx_sc(const char *prefix, __u64 sci, __u8 active, struct > rtattr *rxsc_stats, struct rtattr *sa) > +{ Overall, this looks fine, but could you break some of the really long lines. In general, I like iproute2 to follow kernel style, and in general stick to the 80 column recommendation where it makes sense. Spliting strings or stuff in loops may not make sense. There are several places in this code longer than 100 chars.