On 2020-05-25 4:53 a.m., Andrea Claudi wrote:
Reverting c0325b06382c will for sure fix the segfault identified by
Jamal and get rid of the problems highlighted by Daniel and others.
To fix the s[n]printf truncation warning we can simply check for its
return value. From the snprintf man page:
On Sat, May 23, 2020 at 12:32 PM Jamal Hadi Salim wrote:
>
> On 2020-05-22 9:33 p.m., Daniel Borkmann wrote:
> > On 5/18/20 3:00 PM, Jamal Hadi Salim wrote:
> >> ping?
> >>
> >> Note: these are trivial bug fixes.
> >
> > Looking at c0325b06382c ("bpf: replace snprintf with asprintf when
> > dealin
On 2020-05-22 9:33 p.m., Daniel Borkmann wrote:
On 5/18/20 3:00 PM, Jamal Hadi Salim wrote:
ping?
Note: these are trivial bug fixes.
Looking at c0325b06382c ("bpf: replace snprintf with asprintf when
dealing with long buffers"),
I wonder whether it's best to just revert and redo cleanly from
On 5/18/20 3:00 PM, Jamal Hadi Salim wrote:
ping?
Note: these are trivial bug fixes.
Looking at c0325b06382c ("bpf: replace snprintf with asprintf when dealing with long
buffers"),
I wonder whether it's best to just revert and redo cleanly from scratch.. How
much testing has
been performed o
ping?
Note: these are trivial bug fixes.
cheers,
jamal
On 2020-04-28 12:15 p.m., Jamal Hadi Salim wrote:
Stephen,
What happened to this?
cheers,
jamal
On 2020-04-23 1:58 p.m., Jamal Hadi Salim wrote:
From: Jamal Hadi Salim
Changes from V2:
1) Dont initialize tmp on stack (Stephen)
2)
Stephen,
What happened to this?
cheers,
jamal
On 2020-04-23 1:58 p.m., Jamal Hadi Salim wrote:
From: Jamal Hadi Salim
Changes from V2:
1) Dont initialize tmp on stack (Stephen)
2) Dont look at the return code of snprintf (Dominique)
3) Set errno to EINVAL instead of returning -EINVAL fo
