On 2020-05-22 9:33 p.m., Daniel Borkmann wrote:
On 5/18/20 3:00 PM, Jamal Hadi Salim wrote:
ping?
Note: these are trivial bug fixes.
Looking at c0325b06382c ("bpf: replace snprintf with asprintf when
dealing with long buffers"),
I wonder whether it's best to just revert and redo cleanly from
scratch.. How much testing has
been performed on the original patch? We know it is causing regressions,
and looking Jamal's
2nd patch we do have patterns all over the place wrt error path that go
like:
Reverting c0325b06382c would work as well..
Note: I believe Andrea's original goal was to just get rid of a
compiler warning from sprintf(). Stephen suggested to use
asprintf. Andrea's original solution to get rid of the compiler
warning would suffice. Maybe then an additional code audit to
ensure consistency on usage of s[n]printf could be done and
resolved separately.
Thanks for taking the time Daniel.
cheers,
jamal
