Re: [PATCH iproute2 v2 4/4] testsuite: remove gre kmods if the test loads them

On Sun, 2018-12-16 at 21:21 +0100, Petr Vorel wrote: > Hi Luca, > > Reviewed-by: Petr Vorel > LGTM, but I'd suggest 2 small changes (see bellow). > > > +++ b/testsuite/tests/ip/tunnel/add_tunnel.t > >  TUNNEL_NAME="tunnel_test_ip" > > I'd put KMODS here: > KMODS="ip6_gre ip6_tunnel ip_gre ip_tu

Re: [PATCH iproute2 v2 4/4] testsuite: remove gre kmods if the test loads them

Hi Luca, Reviewed-by: Petr Vorel LGTM, but I'd suggest 2 small changes (see bellow). > +++ b/testsuite/tests/ip/tunnel/add_tunnel.t > TUNNEL_NAME="tunnel_test_ip" I'd put KMODS here: KMODS="ip6_gre ip6_tunnel ip_gre ip_tunnel gre" The reason is maintenance of this script - maybe one day there

[PATCH iproute2 v2 4/4] testsuite: remove gre kmods if the test loads them

The tunnel test leaves behind link devices created by the GRE kernel modules: $ ip -br link ... gre0@NONEDOWN 0.0.0.0 gretap0@NONE DOWN 00:00:00:00:00:00 erspan0@NONE DOWN 00:00:00:00:00:00 ip6tnl0@NONE DOWN :: ip6gre0@NONE DOWN 00:00:00:00: $ lsmod | grep gre ip6_gre 40960 0 ip6_tu