Re: [PATCH iproute2 net-next] iplink: add support for protodown reason

2020-08-28 Thread Roopa Prabhu
On 8/23/20 7:20 PM, David Ahern wrote: External email: Use caution opening links or attachments On 8/20/20 9:52 PM, Roopa Prabhu wrote: +void protodown_reason_n2a(int id, char *buf, int len) +{ + if (id < 0 || id >= PROTODOWN_REASON_NUM_BITS || numeric) { since the reason is limited to

Re: [PATCH iproute2 net-next] iplink: add support for protodown reason

2020-08-28 Thread Roopa Prabhu
On 8/21/20 6:30 PM, Stephen Hemminger wrote: External email: Use caution opening links or attachments On Fri, 21 Aug 2020 14:09:14 -0700 Roopa Prabhu wrote: On 8/20/20 10:18 PM, Roopa Prabhu wrote: On 8/20/20 9:36 PM, Stephen Hemminger wrote: On Thu, 20 Aug 2020 20:52:02 -0700 Roopa Pra

Re: [PATCH iproute2 net-next] iplink: add support for protodown reason

2020-08-23 Thread David Ahern
On 8/20/20 9:52 PM, Roopa Prabhu wrote: > +void protodown_reason_n2a(int id, char *buf, int len) > +{ > + if (id < 0 || id >= PROTODOWN_REASON_NUM_BITS || numeric) { since the reason is limited to 0-31, id > PROTODOWN_REASON_NUM_BITS should be an error. > + snprintf(buf, len, "%d"

Re: [PATCH iproute2 net-next] iplink: add support for protodown reason

2020-08-21 Thread Stephen Hemminger
On Fri, 21 Aug 2020 14:09:14 -0700 Roopa Prabhu wrote: > On 8/20/20 10:18 PM, Roopa Prabhu wrote: > > > > On 8/20/20 9:36 PM, Stephen Hemminger wrote: > >> > >> > >> On Thu, 20 Aug 2020 20:52:02 -0700 > >> Roopa Prabhu wrote: > >> > >>> + if (tb[IFLA_PROTO_DOWN]) { > >>> + if

Re: [PATCH iproute2 net-next] iplink: add support for protodown reason

2020-08-21 Thread Roopa Prabhu
On 8/20/20 10:18 PM, Roopa Prabhu wrote: On 8/20/20 9:36 PM, Stephen Hemminger wrote: On Thu, 20 Aug 2020 20:52:02 -0700 Roopa Prabhu wrote: + if (tb[IFLA_PROTO_DOWN]) { + if (rta_getattr_u8(tb[IFLA_PROTO_DOWN])) + print_bool(PRINT_ANY, +  

Re: [PATCH iproute2 net-next] iplink: add support for protodown reason

2020-08-20 Thread Roopa Prabhu
On 8/20/20 9:36 PM, Stephen Hemminger wrote: On Thu, 20 Aug 2020 20:52:02 -0700 Roopa Prabhu wrote: + if (tb[IFLA_PROTO_DOWN]) { + if (rta_getattr_u8(tb[IFLA_PROTO_DOWN])) + print_bool(PRINT_ANY, +"proto_down", " protodown

Re: [PATCH iproute2 net-next] iplink: add support for protodown reason

2020-08-20 Thread Stephen Hemminger
On Thu, 20 Aug 2020 20:52:02 -0700 Roopa Prabhu wrote: > + if (tb[IFLA_PROTO_DOWN]) { > + if (rta_getattr_u8(tb[IFLA_PROTO_DOWN])) > + print_bool(PRINT_ANY, > +"proto_down", " protodown on ", true); In general my preference is t

[PATCH iproute2 net-next] iplink: add support for protodown reason

2020-08-20 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds support for recently added link IFLA_PROTO_DOWN_REASON attribute. IFLA_PROTO_DOWN_REASON enumerates reasons for the already existing IFLA_PROTO_DOWN link attribute. $ cat /etc/iproute2/protodown_reasons.d/r.conf 0 mlag 1 evpn 2 vrrp 3 psecurity $ ip link set d