On Fri, 21 Aug 2020 14:09:14 -0700
Roopa Prabhu <ro...@nvidia.com> wrote:
> On 8/20/20 10:18 PM, Roopa Prabhu wrote:
> >
> > On 8/20/20 9:36 PM, Stephen Hemminger wrote:
> >>
> >>
> >> On Thu, 20 Aug 2020 20:52:02 -0700
> >> Roopa Prabhu <ro...@cumulusnetworks.com> wrote:
> >>
> >>> + if (tb[IFLA_PROTO_DOWN]) {
> >>> + if (rta_getattr_u8(tb[IFLA_PROTO_DOWN]))
> >>> + print_bool(PRINT_ANY,
> >>> + "proto_down", " protodown on ", true);
> >> In general my preference is to use print_null() for presence flags.
> >> Otherwise you have to handle the false case in JSON as a special case.
> >
> >
> > ok, i will look. But this is existing code moved into a new function and
> > has been
> >
> > working fine for years.
>
>
> looked at print_null and switching to that results in a change in output
> for existing protodown
>
> attribute, so I plan to leave it as is for now.
>
Sure we should really try and have some consistency in the JSON output.
Maybe a JSON style guide is needed, I wonder if some heavy JSON user already
has one?
