Re: [PATCH ethtool v4 0/6] ethtool(1) cable test support

2020-07-05 Thread Michal Kubecek
On Sun, Jul 05, 2020 at 08:25:33PM +0200, Andrew Lunn wrote: > > Hello Andrew, > > > > could you please test this update of netlink/desc-ethtool.c on top of > > your series? The userspace messages look as expected but I'm not sure if > > I have a device with cable test support available to test pr

Re: [PATCH ethtool v4 0/6] ethtool(1) cable test support

2020-07-05 Thread Michal Kubecek
On Sun, Jul 05, 2020 at 06:24:21PM +0200, Andrew Lunn wrote: > On Sun, Jul 05, 2020 at 02:44:47AM +0200, Michal Kubecek wrote: > > On Wed, Jul 01, 2020 at 03:07:37AM +0200, Andrew Lunn wrote: > > > Add the user space side of the ethtool cable test. > > > > > > The TDR output is most useful when fe

Re: [PATCH ethtool v4 0/6] ethtool(1) cable test support

2020-07-05 Thread Andrew Lunn
> Hello Andrew, > > could you please test this update of netlink/desc-ethtool.c on top of > your series? The userspace messages look as expected but I'm not sure if > I have a device with cable test support available to test pretty > printing of kernel messages. (And even if I do, I almost certain

Re: [PATCH ethtool v4 0/6] ethtool(1) cable test support

2020-07-05 Thread Andrew Lunn
On Sun, Jul 05, 2020 at 02:44:47AM +0200, Michal Kubecek wrote: > On Wed, Jul 01, 2020 at 03:07:37AM +0200, Andrew Lunn wrote: > > Add the user space side of the ethtool cable test. > > > > The TDR output is most useful when fed to some other tool which can > > visualize the data. So add JSON supp

Re: [PATCH ethtool v4 0/6] ethtool(1) cable test support

2020-07-04 Thread Michal Kubecek
On Wed, Jul 01, 2020 at 03:07:37AM +0200, Andrew Lunn wrote: > Add the user space side of the ethtool cable test. > > The TDR output is most useful when fed to some other tool which can > visualize the data. So add JSON support, by borrowing code from > iproute2. > > v2: > man page fixes. > > v3

[PATCH ethtool v4 0/6] ethtool(1) cable test support

2020-06-30 Thread Andrew Lunn
Add the user space side of the ethtool cable test. The TDR output is most useful when fed to some other tool which can visualize the data. So add JSON support, by borrowing code from iproute2. v2: man page fixes. v3: More man page fixes. Use json_print from iproute2. v4: checkpatch cleanup etht