On Sun, Jul 05, 2020 at 02:44:47AM +0200, Michal Kubecek wrote:
> On Wed, Jul 01, 2020 at 03:07:37AM +0200, Andrew Lunn wrote:
> > Add the user space side of the ethtool cable test.
> >
> > The TDR output is most useful when fed to some other tool which can
> > visualize the data. So add JSON support, by borrowing code from
> > iproute2.
> >
> > v2:
> > man page fixes.
> >
> > v3:
> > More man page fixes.
> > Use json_print from iproute2.
> >
> > v4:
> > checkpatch cleanup
> > ethtool --cable-test dev
> > Place breakout into cable_test_context
> > Remove Pair: Pair output
>
> Hello Andrew,
>
> could you please test this update of netlink/desc-ethtool.c on top of
> your series? The userspace messages look as expected but I'm not sure if
> I have a device with cable test support available to test pretty
> printing of kernel messages. (And even if I do, I almost certainly won't
> have physical access to it.)
Hi Michal
Currently there are three PHY drivers with support: Marvell, Atheros
at803x, and bcm54140. And you can do some amount of testing without
physical access, you can expect the test results to indicate the cable
is O.K.
However, i will give these a go.
Some sort of capture and reply would be interesting for this, and for
regression testing. The ability to do something like
ethtool --monitor -w test.cap
To dump the netlink socket data to a file, and
ethtool --monitor -r test.cap
to read from the file and decode its contents. Maybe this is already
possible via nlmon?
Andrew
